944813 - zip I/O error: No such file or directory on release builds after bug 926906

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Rail Aliiev [:rail]]

+++ This bug was initially created as a clone of Bug #926906 +++

Copy from https://bugzilla.mozilla.org/show_bug.cgi?id=926906#c6

I think the change introduced in bug 926906 broke release builds. I was doing a staging beta release with the current aurora code and hit the following error on OSX (notice the target zip file name). We need to sort out this before 27.0b1 (12/9/2013).

cp -RL /builds/slave/rel-m-beta-osx64_bld-000000000/build/testing/profiles/prefs_general.js ./dist/test-package-stage/steeplechase
/builds/slave/rel-m-beta-osx64_bld-000000000/build/obj-firefox/i386/config/nsinstall -D ./dist/mac/en-US/
find ./dist/test-package-stage -name "*.pyc" -exec rm {} \;
cd ./dist/test-package-stage && \
	  zip -rq9D "/builds/slave/rel-m-beta-osx64_bld-000000000/build/obj-firefox/i386/dist/mac/en-US/Firefox /builds/slave/rel-m-beta-osx64_bld-000000000/build/obj-firefox/i386/27.0b1.tests.zip" \
	  * -x \*/.mkdir.done
zip I/O error: No such file or directory
zip error: Could not create output file (/builds/slave/rel-m-beta-osx64_bld-000000000/build/obj-firefox/i386/dist/mac/en-US/Firefox /builds/slave/rel-m-beta-osx64_bld-000000000/build/obj-firefox/i386/27.0b1.tests.zip)
make[3]: *** [package-tests] Error 15
make[2]: *** [postflight_all] Error 2
make[1]: *** [realbuild] Error 2
make: *** [build] Error 2

Comment 1

[Mike Hommey [:glandium]]

Attachment: Fix test-package-step after bug 926906

Comment 2

[Rail Aliiev [:rail]]

A staging release with this patch in progress. I'll update the patch with the results.

Thanks for the fast turn around!

Comment 3

[Rail Aliiev [:rail]]

Mac build passed! Waiting for others...

Comment 4

[Rail Aliiev [:rail]]

Linux 32/64 passed as well. I'll update whenever windows build is ready.

Comment 5

[Rail Aliiev [:rail]]

Windows passed too.

Comment 6

[Rail Aliiev [:rail]]

FTR, this needs to be landed on aurora before the merge day (12/9).

Comment 7

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f047d2032ad7

Comment 8

[Mike Hommey [:glandium]]

Comment on attachment 8340559 [details] [diff] [review]
Fix test-package-step after bug 926906

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 926906
User impact if declined: Release build failure
Testing completed (on m-c, etc.): Tested on try by rail.
Risk to taking this patch (and alternatives if risky): Very low
String or IDL/UUID changes made by this patch: None

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f047d2032ad7

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ffc179aca5b7