Closed Bug 944869 Opened 8 years ago Closed 8 years ago

Improve English in alerts ("Proceed it anyway", "Ok")

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: flod, Assigned: steveck)

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
julienw
: review+
arthurcc
: review+
Details | Review
I'm filing this bug under SMS, even if one string is actually in Settings. CCing authors and reviewers of both patches too.

Bug 928330 
https://hg.mozilla.org/gaia-l10n/en-US/rev/5a2e2a2a4cdd

> nonActiveSimConfirm = Ok
This should be "OK", not "Ok" (like all the others landed in this changeset). This kind of errors can be fixed without using a new ID for the string.

> nonActiveSimBody = Switch the data connection to {{ nonactive }} to retrieve the MMS. The current data transfer on {{ active }} will be suspended. Proceed it anyway?

Bug 932731
http://hg.mozilla.org/gaia-l10n/en-US/rev/2009afb472ec
> change-outgoing-data-confirm=The current data transfer will be suspended. Proceed it anyway?

"Proceed it anyway?" should be "Proceed anyway?" (verb is intransitive). But to be honest I don't recall the verb "proceed" being much used in Mozilla. If the change is only to remove "it", it's OK to fix it without a new ID.

Needinfo Matej to see what he thinks, since English is far from being my primary language.
Flags: needinfo?(Mnovak)
"Continue anyway" would be a little friendlier, but I'm OK with "Proceed."

Either way, "it" should definitely be removed.

Thanks.
Flags: needinfo?(Mnovak)
Steve, will you handle this? I can review it real quick then!

Francesco, you're perfectly right, I should have reviewed this as well, sorry.
Flags: needinfo?(schung)
Attached file Link to github
Hi Julien, I commited a quick patch without changing the ID. Ping me if you think it's necessary to change the ID, thanks.
Attachment #8341509 - Flags: review?(felash)
Flags: needinfo?(schung)
Not sure if you want to fix the string in Settings as well.
(In reply to Francesco Lodolo [:flod] from comment #4)
> Not sure if you want to fix the string in Settings as well.

OK, I also updated settings part. ni? l10n team to make sure whether we need to change the string ID or not since these two patches just landed few days ago.
Flags: needinfo?(l10n)
Attachment #8341509 - Flags: review?(arthur.chen)
Assignee: nobody → schung
(In reply to Steve Chung [:steveck] from comment #5)
> (In reply to Francesco Lodolo [:flod] from comment #4)
> > Not sure if you want to fix the string in Settings as well.
> 
> OK, I also updated settings part. ni? l10n team to make sure whether we need
> to change the string ID or not since these two patches just landed few days
> ago.

Clearing Pike's needinfo (I think he's traveling today). 

Considering the king of change – "Proceed anyway" and "Continue anyway" have the same exact meaning – you don't need new IDs, so localizers don't need to notice the new version.
Flags: needinfo?(l10n)
Comment on attachment 8341509 [details] [review]
Link to github

r=me for the sms part

FWIW I feel confident enough to say r=me for the settings part too, so please land it :) Of course you can still wait for arthur's r+ if you feel it's needed.
Attachment #8341509 - Flags: review?(felash) → review+
Comment on attachment 8341509 [details] [review]
Link to github

r=me. Thanks!
Attachment #8341509 - Flags: review?(arthur.chen) → review+
Since sim card manager has been back-out, I only fixed message part in this patch. Hi Arthur, Please be noticed that the l10n string need to be polished("Proceed it anyway" => "Continue anyway").

Landed in master: 8b5ec594006fc447cb845bb2c6028a4c092293ec

Francesco, Julien:
Thanks for the feedback and review!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Thanks for your reminding, Steve.

I will update the the string from "proceed it anyway" to "continue anyway" in bug 932731.
You need to log in before you can comment on or make changes to this bug.