944881 - Gaia should interpret timestamps as long-long numbers

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Gene Lian (I already quit Mozilla)]

+++ This bug was initially created as a clone of Bug #939302 +++

Bug 939302 is going to change all the timestamps to be long-long numbers. Gaia needs to have corresponding changes to avoid breaking the backward compatibility.

This one should be marked as V1.3 because it blocks Bug 939302 which is a blocker of V1.3.

Comment 1

[Gene Lian (I already quit Mozilla)]

Attachment: Patch (WIP)

Hi Steve,

As title, we are going to change all the timestamps to be long-long numbers due to bug 939302, including {sms,mms}timestamp, {sms,mms}deliveryTimestamp, {sms,mms}readTimestamp and thread.timestamp.

This is just a quick WIP patch to address what we're going to do. I'd appreciate if you could take over the Gaia part.

One strange thing is, what I can only see in the current Gaia master is thread.timestamp. How about others like deliveryTimestamp you're working on?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Why is security sensitive?

Comment 3

[Steve Chung [:steveck]]

deliveryTimestamp is still in WIP bug 933131, I will also apply the changes in the patch. This changes will also need for desktop mock and unit test. If you have any question about the test or have no cycle to finish all these stuff, please let me know, thanks.

Comment 4

[Gene Lian (I already quit Mozilla)]

Per off-line discussion, Steve can help take over this.

Comment 5

[Julien Wajsberg [:julienw]]

Can I have access to Bug #939302 please?

Comment 6

[Boris Zbarsky [:bzbarsky]]

Done.

Comment 7

[Gene Lian (I already quit Mozilla)]

Hi Steve, please see bug 939302, comment #41 which might be a better approach to keep the backward compatibility.

Comment 8

[Rick Waldron [:rwaldron]]

(In reply to Boris Zbarsky [:bz] from comment #6)
> Done.

Can you grant me access as well? Thanks

Comment 9

[Gene Lian (I already quit Mozilla)]

Done. :)

Comment 10

[Julien Wajsberg [:julienw]]

I think that we always convert the Date to a timestamp (using getTime()) and really use a timestamp in the sms code, so let's just use "+timestamp" instead of calling getTime() :)

Comment 11

[Steve Chung [:steveck]]

Comment on attachment 8340633 [details] [diff] [review]
Patch (WIP)

Clear feedback and thanks for the tip!

Comment 12

[Gene Lian (I already quit Mozilla)]

Hi Joe, we need to mark this as V1.3+ because this bug blocks Bug 939302 which is a V1.3+ blocker.

Comment 13

[Steve Chung [:steveck]]

Attachment: Link to github

Hi Julien, this patch force all timestamp related properties to long int(and also changed unit test/mock and desktop test). I'll also fix delivery timestamp in bug 933131 once this patch landed, thanks.

Comment 14

[Julien Wajsberg [:julienw]]

Comment on attachment 8345340 [details] [review]
Link to github

Looks good, mostly nits, and one oversight.

I'd like to wait for another pass before giving r+ but I think it will be fine at the next review!

Comment 15

[Steve Chung [:steveck]]

Comment on attachment 8345340 [details] [review]
Link to github

Hi Julien, another commit for your suggestions, thanks for the feedback!

Comment 16

[Joe Cheng [:jcheng] (please needinfo)]

blocks a blocker. 1.3+

Comment 17

[Julien Wajsberg [:julienw]]

Comment on attachment 8345340 [details] [review]
Link to github

r=me

thanks! easy patch, but so boring ;)

Comment 18

[Steve Chung [:steveck]]

Landed in master: 87345e3947da71386552561d5f15109955d4fe15

Comment 19

[Gene Lian (I already quit Mozilla)]

Need someone's help to land this to V1.3 branch for Gaia and then we can then bug 939302.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

v1.3: 8d21e3cbea1cc8515c460e1d2427e1a161812ddb