944892 - Debug build fails to build with -Werror=int-to-pointer-cast

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[sylvestre]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:23.0) Gecko/20100101 Firefox/23.0 Iceweasel/23.0.1 (Beta/Release)
Build ID: 20130821135347

Steps to reproduce:

When forcing -Werror=int-to-pointer-cast globally (see bug 781552), the debug build fails with:

../../../tools/trace-malloc/tmreader.c: In function 'tmreader_eventloop':
../../../tools/trace-malloc/tmreader.c:527:19: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
../../../tools/trace-malloc/tmreader.c:548:19: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]


See: 
https://tbpl.mozilla.org/php/getParsedLog.php?id=31262559&tree=Try&full=1

Comment 1

[u493164]

Hi,

I'd like to fix this bug.

Comment 2

[u493164]

Attachment: bug944892.diff

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8350182 [details] [diff] [review]
bug944892.diff

Seems better to add the necessary casts than to suppress the warning.

Comment 4

[u493164]

ok David, I'll do that.

Comment 5

[u493164]

Attachment: bug944892_v2.diff

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8362994 [details] [diff] [review]
bug944892_v2.diff

https://hg.mozilla.org/integration/mozilla-inbound/rev/a8d637b029a7

In the future, you can just use the checkin-needed bug keyword instead of requesting checkin from a specific person. Also, please make sure that future patches have the needed commit information included in them. Makes life much easier for those landing on your behalf :)
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a8d637b029a7