944952 - Bring mdimporter source into the regular build config

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Joshua Cranmer [:jcranmer]]

Attachment: port-xcode-project

After asking around a bit, it sounds like the mdimporter xcode project is nothing more complicated than "copy some files" and "compile a binary." Both of these things can easily be specified within our makefile system, so we can simplify some build-config by eliminating the xcode project.

[The diff to schema.strings is converting it from a UTF-16BE to a UTF-16LE file.]

Try push: <https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=66bc27ad262a>

I'm marking this as blocking cc-rework because the current xcode project logic would need moving from config/config.mk to the more local makefiles, and it's easier to just eliminate it altogether.

(As I don't have a mac to develop or test on, the changes are completely untested beyond making sure that it compiles on try).

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Not removing the stuff in config.mk here?

Comment 2

[Joshua Cranmer [:jcranmer]]

Comm-central's config.mk is so far out-of-date at this point that I'll let it stay in there until cc-rework eliminates the file altogether.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8340717 [details] [diff] [review]
port-xcode-project

This doesn't quite work - the output structure is wrong. On my mac, in $(DIST)/package/thunderbird.mdimporter I have on an unpatched build:

.
./Contents
./Contents/Info.plist
./Contents/MacOS
./Contents/MacOS/thunderbird
./Contents/Resources
./Contents/Resources/English.lproj
./Contents/Resources/English.lproj/InfoPlist.strings
./Contents/Resources/English.lproj/schema.strings
./Contents/Resources/schema.xml

Comment 4

[Joshua Cranmer [:jcranmer]]

Attachment: port-xcode-project

This one should work better.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8366456 [details] [diff] [review]
port-xcode-project

Review of attachment 8366456 [details] [diff] [review]:
-----------------------------------------------------------------

That's better. Seems to work fine. There's an extra (empty) chrome directory created in Library/Spotlight/thunderbird.mdimporter/Contents/MacOS, but I'm not too fussed about that. r=Standard8

Comment 6

[Joshua Cranmer [:jcranmer]]

https://hg.mozilla.org/comm-central/rev/24c3a939f322