Build rdf in unified mode

RESOLVED FIXED in mozilla28

Status

()

Core
RDF
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

Trunk
mozilla28
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 8340734 [details] [diff] [review]
unify-rdf.patch

To build rdf in unified mode, I moved some gLog static file variables to static class member variables and moved some NS_DEFINE_CIDs from static file variables to local variables (where the CIDs are usually only constructed and used once).
Attachment #8340734 - Flags: review?(axel)

Comment 1

4 years ago
Comment on attachment 8340734 [details] [diff] [review]
unify-rdf.patch

Review of attachment 8340734 [details] [diff] [review]:
-----------------------------------------------------------------

I'd prefer Benjamin to do the real review here, it's been too long since I've done actual coding. I'm also following the thread in .platform, which tells me that I should probably know more about what that does to code to do a real review.

The only thing that looks mildly hot-path is the QI of the content sink, AFAICT.
Attachment #8340734 - Flags: review?(benjamin)
Attachment #8340734 - Flags: review?(axel)
Attachment #8340734 - Flags: feedback+

Comment 2

4 years ago
Trevor has done something similar to this in bug 943023 which has not landed yet...

Updated

4 years ago
Attachment #8340734 - Flags: review?(benjamin) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/58dbd2146e24
Backed out for bustage.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a683f61403a1

https://tbpl.mozilla.org/php/getParsedLog.php?id=31405476&tree=Mozilla-Inbound
(Assignee)

Comment 5

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/42ebb2419d34

https://tbpl.mozilla.org/?tree=Try&rev=5b4b75afefa9
https://hg.mozilla.org/mozilla-central/rev/42ebb2419d34
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Updated

4 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.