Closed Bug 944961 Opened 6 years ago Closed 6 years ago

Build rdf in unified mode

Categories

(Core Graveyard :: RDF, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla28

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Attached patch unify-rdf.patchSplinter Review
To build rdf in unified mode, I moved some gLog static file variables to static class member variables and moved some NS_DEFINE_CIDs from static file variables to local variables (where the CIDs are usually only constructed and used once).
Attachment #8340734 - Flags: review?(axel)
Comment on attachment 8340734 [details] [diff] [review]
unify-rdf.patch

Review of attachment 8340734 [details] [diff] [review]:
-----------------------------------------------------------------

I'd prefer Benjamin to do the real review here, it's been too long since I've done actual coding. I'm also following the thread in .platform, which tells me that I should probably know more about what that does to code to do a real review.

The only thing that looks mildly hot-path is the QI of the content sink, AFAICT.
Attachment #8340734 - Flags: review?(benjamin)
Attachment #8340734 - Flags: review?(axel)
Attachment #8340734 - Flags: feedback+
Trevor has done something similar to this in bug 943023 which has not landed yet...
Attachment #8340734 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/42ebb2419d34
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.