944961 - Build rdf in unified mode

Status: RESOLVED FIXED

(Core Graveyard :: RDF, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: unify-rdf.patch

To build rdf in unified mode, I moved some gLog static file variables to static class member variables and moved some NS_DEFINE_CIDs from static file variables to local variables (where the CIDs are usually only constructed and used once).

Comment 1

[Axel Hecht]

Comment on attachment 8340734 [details] [diff] [review]
unify-rdf.patch

Review of attachment 8340734 [details] [diff] [review]:
-----------------------------------------------------------------

I'd prefer Benjamin to do the real review here, it's been too long since I've done actual coding. I'm also following the thread in .platform, which tells me that I should probably know more about what that does to code to do a real review.

The only thing that looks mildly hot-path is the QI of the content sink, AFAICT.

Comment 2

[(no longer active)]

Trevor has done something similar to this in bug 943023 which has not landed yet...

Comment 3

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/58dbd2146e24

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out for bustage.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a683f61403a1

https://tbpl.mozilla.org/php/getParsedLog.php?id=31405476&tree=Mozilla-Inbound

Comment 5

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/42ebb2419d34

https://tbpl.mozilla.org/?tree=Try&rev=5b4b75afefa9

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/42ebb2419d34