Update Music app object to use Marionette Actions for tapping

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bsilverberg, Unassigned)

Tracking

unspecified
Other
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-v1.2 affected)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Because of bug 862156, we have to use Actions instead of just the basic tap() in the music app. I have experimented with this and have gotten it to work. I will update the music app object after bug 921514 lands.

Comment 1

4 years ago
I suspect that there are several places where you have to use Actions instead of tap.
One is known blocker for test, another one is tapping on "play" button on player view (I tried to test my code for player_view object, and it seems that marionette thinks that play button is invisible too).
(Reporter)

Comment 2

4 years ago
Created attachment 8341048 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14260

Pointer to Github pull-request
(Reporter)

Updated

4 years ago
Attachment #8341048 - Flags: review?(zcampbell)
Attachment #8341048 - Flags: review?(viorela.ioia)
Attachment #8341048 - Flags: review?(trifandreialin)
Attachment #8341048 - Flags: review?(florin.strugariu)
Attachment #8341048 - Flags: review?(andrei.hutusoru)
(Reporter)

Updated

4 years ago
status-b2g-v1.2: --- → affected
Comment on attachment 8341048 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14260

except for Zac's comments all looks OK
Attachment #8341048 - Flags: review?(florin.strugariu) → review+

Comment 4

4 years ago
Comment on attachment 8341048 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14260

Beside zac's comments, LGTM
Attachment #8341048 - Flags: review?(andrei.hutusoru) → review+

Comment 5

4 years ago
Comment on attachment 8341048 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14260

r+ from me! great getting coverage back!
Attachment #8341048 - Flags: review?(zcampbell) → review+

Comment 6

4 years ago
Merged for master:
https://github.com/mozilla-b2g/gaia/commit/899031046f3b5d16b96272a51f34d7ab4a413acd

Go forth on v1.2
Comment on attachment 8341048 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14260

reviews no longer required
Attachment #8341048 - Flags: review?(viorela.ioia)
Attachment #8341048 - Flags: review?(trifandreialin)

Comment 8

4 years ago
Created attachment 8341737 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14317

Pointer to Github pull-request

Comment 9

4 years ago
Comment on attachment 8341737 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14317

Uplifted to v1.2
Attachment #8341737 - Flags: review?(trifandreialin)
Attachment #8341737 - Flags: review?(florin.strugariu)
Attachment #8341737 - Flags: review?(bob.silverberg)
Comment on attachment 8341737 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14317

r+
Attachment #8341737 - Flags: review?(trifandreialin) → review+
(Reporter)

Comment 11

4 years ago
Comment on attachment 8341737 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14317

Let's merge this when the tree reopens.
Attachment #8341737 - Flags: review?(bob.silverberg) → review+
(Reporter)

Updated

4 years ago
Assignee: bob.silverberg → nobody
Merged:
Master:
https://github.com/mozilla-b2g/gaia/commit/899031046f3b5d16b96272a51f34d7ab4a413acd


v1.2
https://github.com/mozilla-b2g/gaia/commit/c328876833aa3a926df176f8b0d6b5ae576ed42f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Attachment #8341737 - Flags: review?(florin.strugariu) → review+
You need to log in before you can comment on or make changes to this bug.