Closed Bug 945024 Opened 7 years ago Closed 7 years ago

Some icons in folderPane are showing the folder icon instead the special icon

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Platform:
All
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 28.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files)

Screenshot of issue
8.27 KB, image/png
Details
patch
5.00 KB, patch
jsbruner
: review+
Details | Diff | Splinter Review
Attached image Screenshot of issue — 
Since the 20131128 build some special folders like Inbox, Archive etc. in folderPane are showing the folder icon instead their special icon.

Checking the code shows treechildren::-moz-tree-image(folderNameCol, selected, open) is more specific than treechildren::-moz-tree-image(folderNameCol, specialFolder-Inbox) with it's 3 selectors than the 2 selectors for the inbox. I don't know why this worked until now and what changed to appear now.

This only happens on Windows. Linux and OS X aren't using a selector for 'open'.
Attached patch patch — — Splinter Review 
This patch adds the 'open' selector to the special folders to be more specific.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8340786 - Flags: review?(josiah)
Comment on attachment 8340786 [details] [diff] [review]
patch

Review of attachment 8340786 [details] [diff] [review]:
-----------------------------------------------------------------

Though I can't test it, the code looks perfectly fine and I believe you that it works. Thanks!
Attachment #8340786 - Flags: review?(josiah) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/0fa8a688fa1e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 28.0
You need to log in before you can comment on or make changes to this bug.