945025 - widget/gonk/nsAppShell.cpp:334: warning: 'orientation' is used uninitialized in this function

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Description

[Daniel Holbert [:dholbert]]

Legit build warning when compiling in widget/gonk:
{
widget/gonk/nsAppShell.cpp:334: warning: 'orientation' is used uninitialized in this function
}

Link to source:
http://mxr.mozilla.org/mozilla-central/source/widget/gonk/nsAppShell.cpp?rev=8c1cc3f587a7#327

The code that initialized this variable was removed here, in bug 908797:
http://hg.mozilla.org/mozilla-central/diff/0b914f0e61ab/widget/gonk/nsAppShell.cpp

but our behavior still depends on the (now-uninitialized) contents of this variable.

mwu, what should be happening here?

Comment 1

[Michael Wu [:mwu]]

Thanks for catching this! This code is only applicable to mouse input, so I guess that's why nobody has noticed bad behavior. I'll fix this.

Comment 2

[Michael Wu [:mwu]]

Attachment: Fix bound calculation in GeckoPointerController

Comment 3

[Michael Wu [:mwu]]

Comment on attachment 8341229 [details] [diff] [review]
Fix bound calculation in GeckoPointerController

This seems to work. Tested on a dev board with a mouse in both landscape and portrait.

Comment 4

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/b2g-inbound/rev/59bb5272674d

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/59bb5272674d