Closed Bug 945025 Opened 6 years ago Closed 6 years ago

widget/gonk/nsAppShell.cpp:334: warning: 'orientation' is used uninitialized in this function

Categories

(Core Graveyard :: Widget: Gonk, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla28

People

(Reporter: dholbert, Assigned: mwu)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

Legit build warning when compiling in widget/gonk:
{
widget/gonk/nsAppShell.cpp:334: warning: 'orientation' is used uninitialized in this function
}

Link to source:
http://mxr.mozilla.org/mozilla-central/source/widget/gonk/nsAppShell.cpp?rev=8c1cc3f587a7#327

The code that initialized this variable was removed here, in bug 908797:
http://hg.mozilla.org/mozilla-central/diff/0b914f0e61ab/widget/gonk/nsAppShell.cpp

but our behavior still depends on the (now-uninitialized) contents of this variable.

mwu, what should be happening here?
Flags: needinfo?(mwu)
Thanks for catching this! This code is only applicable to mouse input, so I guess that's why nobody has noticed bad behavior. I'll fix this.
Assignee: nobody → mwu
Flags: needinfo?(mwu)
Comment on attachment 8341229 [details] [diff] [review]
Fix bound calculation in GeckoPointerController

This seems to work. Tested on a dev board with a mouse in both landscape and portrait.
Attachment #8341229 - Flags: review?(mvines)
Keywords: regression
Attachment #8341229 - Flags: review?(mvines) → review+
https://hg.mozilla.org/mozilla-central/rev/59bb5272674d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.