Closed Bug 945033 Opened 6 years ago Closed 6 years ago

Silence 2 WARNINGs: no preprocessor directives found

Categories

(Firefox Build System :: General, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
mozilla28

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

During compiling Firefox, I see these warnings:
/m/trunk/browser/base/content/sync/setup.xul: WARNING: no preprocessor directives found
/m/trunk/browser/base/content/sync/setup.js: WARNING: no preprocessor directives found

This is a leftover from the removal of the #ifdefs in bug 924900.
Attachment #8340796 - Flags: review?(netzen)
Comment on attachment 8340796 [details] [diff] [review]
silence-no-preprocessor-directives-warnings.diff

Review of attachment 8340796 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch!
Attachment #8340796 - Flags: review?(netzen) → review+
https://hg.mozilla.org/integration/fx-team/rev/18c0c2f2d32c
Target Milestone: --- → Firefox 28
https://hg.mozilla.org/mozilla-central/rev/18c0c2f2d32c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 28 → mozilla28
You need to log in before you can comment on or make changes to this bug.