Closed Bug 945063 Opened 6 years ago Closed 6 years ago

Mark storage/build and storage/test as FAIL_ON_WARNINGS

Categories

(Toolkit :: Storage, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

storage/build and storage/test are build-warning-free. Let's annotate them as FAIL_ON_WARNINGS to keep it that way.
Attached patch fixSplinter Review
Attachment #8340828 - Flags: review?(mak77)
This is green on Try.

More details: Here's a Try run with an earlier version of this patch, which also annotated storage/src. This Try run was green everywhere except Windows, since there's apparently a windows-only build warning in storage/src.
 https://tbpl.mozilla.org/?tree=Try&rev=2f4dd2235e24

And here's a Windows-only Try run with the actual attached patch -- i.e. without any storage/src annotation -- which is green:
 https://tbpl.mozilla.org/?tree=Try&rev=1217b8db5131

So collectively, those Try runs demonstrate that the attached patch builds successfully everywhere.
Comment on attachment 8340828 [details] [diff] [review]
fix

Review of attachment 8340828 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks
Attachment #8340828 - Flags: review?(mak77) → review+
https://hg.mozilla.org/mozilla-central/rev/50e2f15969ec
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.