945063 - Mark storage/build and storage/test as FAIL_ON_WARNINGS

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect)

Description

[Daniel Holbert [:dholbert]]

storage/build and storage/test are build-warning-free. Let's annotate them as FAIL_ON_WARNINGS to keep it that way.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Daniel Holbert [:dholbert]]

This is green on Try.

More details: Here's a Try run with an earlier version of this patch, which also annotated storage/src. This Try run was green everywhere except Windows, since there's apparently a windows-only build warning in storage/src.
 https://tbpl.mozilla.org/?tree=Try&rev=2f4dd2235e24

And here's a Windows-only Try run with the actual attached patch -- i.e. without any storage/src annotation -- which is green:
 https://tbpl.mozilla.org/?tree=Try&rev=1217b8db5131

So collectively, those Try runs demonstrate that the attached patch builds successfully everywhere.

Comment 3

[Marco Bonardo [:mak] (Away July 4-13)]

Comment on attachment 8340828 [details] [diff] [review]
fix

Review of attachment 8340828 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/50e2f15969ec

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/50e2f15969ec