Mark storage/build and storage/test as FAIL_ON_WARNINGS

RESOLVED FIXED in mozilla29

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla29
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
storage/build and storage/test are build-warning-free. Let's annotate them as FAIL_ON_WARNINGS to keep it that way.
(Assignee)

Comment 1

5 years ago
Created attachment 8340828 [details] [diff] [review]
fix
Attachment #8340828 - Flags: review?(mak77)
(Assignee)

Comment 2

5 years ago
This is green on Try.

More details: Here's a Try run with an earlier version of this patch, which also annotated storage/src. This Try run was green everywhere except Windows, since there's apparently a windows-only build warning in storage/src.
 https://tbpl.mozilla.org/?tree=Try&rev=2f4dd2235e24

And here's a Windows-only Try run with the actual attached patch -- i.e. without any storage/src annotation -- which is green:
 https://tbpl.mozilla.org/?tree=Try&rev=1217b8db5131

So collectively, those Try runs demonstrate that the attached patch builds successfully everywhere.
Comment on attachment 8340828 [details] [diff] [review]
fix

Review of attachment 8340828 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks
Attachment #8340828 - Flags: review?(mak77) → review+
https://hg.mozilla.org/mozilla-central/rev/50e2f15969ec
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.