945068 - Incorrect dimensions in image preview

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Fernando García Gómez, stripTM]

Attachment: developer_tools_img_dimensions.html

The image size information is not correct, the dimensions corresponds to the preview, not those of the original image.

In the test case the image (980px x 720px) show 400 x 110.

Original bug #765105

Comment 1

[Patrick Brosset <:pbro>]

Attachment: bug945068-tooltip-image-dimension.patch

Patch that solves the image dimension problem and adds new test assertions.
The problem was that after the size was retrieved, it was lost when resolving the tooltipData promise.

Ongoing try build for this patch: https://tbpl.mozilla.org/?tree=Try&rev=7861a4cf78ed

Comment 2

[Patrick Brosset <:pbro>]

Thanks Heather!

Comment 3

[Matthew N. [:MattN]]

(In reply to Patrick Brosset [:pbrosset] from comment #1)
> Ongoing try build for this patch:
> https://tbpl.mozilla.org/?tree=Try&rev=7861a4cf78ed

I'm seeing a 10.6 failure on the try push:
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/markupview/test/browser_inspector_markup_765105_tooltip.js | Tooltip label for [img.local] displays the right image size - Got Could not load the image, expected 192 x 192

Comment 4

[Patrick Brosset <:pbro>]

Sorry, I don't know how I missed this.

Comment 5

[Patrick Brosset <:pbro>]

Attachment: bug945068-tooltip-image-dimension V2.patch

Simple change compared the 1st version of this patch in the way dimensions are displayed in the tooltip:
Now, if dimensions have already been retrieved (which is always the case for the markup-view), no need to wait for the image load to display them.

New try build: https://tbpl.mozilla.org/?tree=Try&rev=ca8bbc8e8c4f

Comment 6

[Patrick Brosset <:pbro>]

Try build is green

Comment 7

[Patrick Brosset <:pbro>]

Attachment: bug945068-tooltip-image-dimension V3.patch

Simple rebase, so carrying the R+ over.

Comment 8

[Patrick Brosset <:pbro>]

Fixed in fx-team: https://hg.mozilla.org/integration/fx-team/rev/482380835b2a

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/482380835b2a