945074 - give nsTextFrames within continuing nsFirstLetter frames a style context that inherits from what the nsFirstLetter inherits from

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Cameron McCormack (:heycam)]

When we create a continuing nsTextFrame as part of the initial reflow of an nsFirstLetterFrame, we restyle the new nsTextFrame so that it doesn't have the ::first-line style.  This is done in nsFirstLetterFrame::DrainOverflowFrames.  However, we give it a style context that inherits from the continuing nsFirstLetterFrame, rather than inheriting from whatever the nsFirstLetterFrame inherits from.  Later on, a restyle will fix up this style context inheritance, but it would be better to get it right from the start.  (Especially as once bug 931668 is complete, we may not get to restyle the nsTextFrame.)

Comment 1

[Cameron McCormack (:heycam)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8340845 [details] [diff] [review]
patch

r=dbaron; sorry for the delay

Comment 3

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/114c763763b0

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/114c763763b0