bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

give nsTextFrames within continuing nsFirstLetter frames a style context that inherits from what the nsFirstLetter inherits from

RESOLVED FIXED in mozilla29

Status

()

Core
Layout
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: heycam, Assigned: heycam)

Tracking

Trunk
mozilla29
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
When we create a continuing nsTextFrame as part of the initial reflow of an nsFirstLetterFrame, we restyle the new nsTextFrame so that it doesn't have the ::first-line style.  This is done in nsFirstLetterFrame::DrainOverflowFrames.  However, we give it a style context that inherits from the continuing nsFirstLetterFrame, rather than inheriting from whatever the nsFirstLetterFrame inherits from.  Later on, a restyle will fix up this style context inheritance, but it would be better to get it right from the start.  (Especially as once bug 931668 is complete, we may not get to restyle the nsTextFrame.)
(Assignee)

Comment 1

5 years ago
Created attachment 8340845 [details] [diff] [review]
patch
Attachment #8340845 - Flags: review?(dbaron)
(Assignee)

Updated

5 years ago
Blocks: 931668
Comment on attachment 8340845 [details] [diff] [review]
patch

r=dbaron; sorry for the delay
Attachment #8340845 - Flags: review?(dbaron) → review+
(Assignee)

Updated

5 years ago
OS: Mac OS X → All
Hardware: x86 → All
https://hg.mozilla.org/mozilla-central/rev/114c763763b0
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.