945080 - "White dots" appears above and below the camera icon for 1.5dppx phones

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #919410 +++

STR:

1. With lock screen enabled, look at the lock screen handle.

Expected:

1. The semi-transparent borders surrounds icons and handle perfectly. 

Actually:

1. "White dots" appears above and below the camera icon for 1.5dppx phones, caused by overlapping semi-transparent borders.

Greg, would you be able to deliver a quick fix on this? It might be better if we change the CSS rules to avoid problem like this. Talk to me in person if you need anything.

Blocking: Should block release because Andreas said lock screen has to be prefect.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

The border itself is not perfectly surrounds the blue handle if you drag it all the way left/right on a 1.5dppx phone either.

How about drawing the border with the <canvas> element itself? That *should* be prefect right? But I am not sure if using border-radius on canvas will trigger any sub-optimal rendering path on Gecko though.

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

Re-implemented the way to draw the border with Canvas for this bug.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8340977 [details] [review]
Patch

Thanks!

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

Travis was green: https://travis-ci.org/mozilla-b2g/gaia/builds/14848134

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/bcf883fb1b5103ff94d89c80d497f9fe36b62aa1

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

--- since the bug has already made to v1.3.