945096 - Re-implement locked call screen with canvas

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #919410 +++

With bug 919410 lock screen unlock handle have been updated with a canvas implementation. We should updated the locked call screen too to avoid many issues we see in the previous implementation.

The canvas implementation is self-isolated in a LockScreenHandle class, which can be reused.

The current call screen is actually appear broken on hi-res phone too...

Blocking: this should block because the current implementation is visually broken, and even if that's fixed, there will still be some visual glitches (bug 919899, bug 920724, etc.) only fixable with the new implementation.

Joe, David, could you prioritize this work? Thanks.

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

this will be discussed in weekly comms triage

Comment 2

[David Scravaglieri [:scravag]]

n? to rik & etienne. what would be your feedback regarding this bug ?

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

triage: not blocking release but let's have steve continue working on this during first couple sprints in 1.3 convergence and then ask for approval to uplift

Comment 4

[Anthony Ricaud (:rik)]

Steve is working on this so clearing needinfos.

Comment 5

[Steve Chung [:steveck]]

Attachment: Link to github

Hi Etienne, I removed the original swipe.js and apply the shared lockscreen slider module here. The html/css are still in the dialer because there is no proper place for them, but any feedback or suggestion for better framework is welcome :)
Hi Greg, I also made some changes and suggestion in slider module and system lockscreen, may need your feedback for these fixing.

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8348785 [details] [review]
Link to github

Replied on GitHub.

Comment 7

[Etienne Segonzac (:etienne)]

Comment on attachment 8348785 [details] [review]
Link to github

Comments on github.

The main one being the the re-organisation in call_screen.js and the tests to add.

Comment 8

[Steve Chung [:steveck]]

Comment on attachment 8348785 [details] [review]
Link to github

Hi Etienne, I've put the module in proper place with some test cases, thanks!

Comment 9

[Joe Cheng [:jcheng] (please needinfo)]

triage: blocker for bug 948523. retriage to 1.3+

Comment 10

[Etienne Segonzac (:etienne)]

Comment on attachment 8348785 [details] [review]
Link to github

r=me with the unit test failure fixed

'incoming-locked screen init without layout set'
'incoming-locked screen init with layout set'

should be put in a sub-suite with something like:
```
      var oldHash;
      setup(function() {
        oldHash = window.location.hash;
        window.location.hash = '#locked';
      });

      teardown(function() {
        window.location.hash = oldHash;
      });

```

Comment 11

[Steve Chung [:steveck]]

Patch fixed and merged in master: 725c570d8c5b9528ed7ebce36c43e1ce776c9f21
Thanks for the review!

Comment 13

[Steve Chung [:steveck]]

Uplift to v1.3: ae7d05689b6b9ac4ec6182217dfdef06be28e886