Closed Bug 945198 Opened 12 years ago Closed 12 years ago

[e.me] Guid cleanup no longer needed

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: amirn, Assigned: amirn)

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
ranbena
: review+
Details | Review
Currently guids (manifestURL or BookmarkURL) are cleaned from query strings on the client side before making nativeInfo requests. For example, for the Twitter app, the manifestURL is: https://mobile.twitter.com/cache/twitter.webapp?feature_profile=3ebdd4ff37b6.46.3 hence the guid will be: https://mobile.twitter.com/cache/twitter.webapp The server now handles cleanup instead.
Assignee: nobody → amirn
Attached file Redirect to PR
Attachment #8341620 - Flags: review?(ran)
Amir, could this be partially done with a commit revert?
Flags: needinfo?(amirn)
(In reply to Ran Ben Aharon (Everything.me) from comment #2) > Amir, could this be partially done with a commit revert? only partially since the commit introduced other changes as well: https://github.com/EverythingMe/gaia/commit/70b0b668ba77bc753ee5dc2022e0e18579e0711b
Flags: needinfo?(amirn)
Attachment #8341620 - Flags: review?(ran) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: