945235 - Uplift {menu, tool, location, status}bars visibility fix to b2g (desktop)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Alexandre Poirot [:ochameau]]

In the simulator, we have a fix to set all bars "visible" attribute to false.
(By default they are all considered as visible.)

"
Apps are checking if they run chromeless using window.locationbar.visible. In B2G and on Desktop this values is consistently false when the app runs in chromeless mode.

Affects a lot of apps, as its still a recommendation mentioned in the MDN [1].
"

Actually, on device, bars are considered hidden only in OOP apps, they are still considered visible when running in parent process.

[1] https://developer.mozilla.org/en-US/Apps/FAQs/About_apps#How_can_my_app_detect_that_it_is_in_the_Web_runtime.3F

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Tweak toolkit.defaultChromeFeatures

defaultChromeFeatures by default set "all", which set all these flags,
from WINDOW_BORDERS to CHROME_EXTRA:
  http://mxr.mozilla.org/mozilla-central/source/embedding/browser/webBrowser/nsIWebBrowserChrome.idl#45
Whereas we don't really expect all *bars one to be set.

So I tried to be conservative, by still setting all non-bars ones.
(After some tests, scrollbars and resizable are really needed. Others *seems* to be useless.)
I can be even more conservative and only set that on desktop.
But keep in mind that it is also wrong on device, with apps living in parent process.

https://tbpl.mozilla.org/?tree=Try&rev=f3f9c552bc9a

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 8341125 [details] [diff] [review]
Tweak toolkit.defaultChromeFeatures

fabrice, may you review this or forward this review to whoever should review such patch?

Comment 3

[[:fabrice] Fabrice Desré]

Comment on attachment 8341125 [details] [diff] [review]
Tweak toolkit.defaultChromeFeatures

Review of attachment 8341125 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Note that no app should ever run in the parent process.

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 8341125 [details] [diff] [review]
Tweak toolkit.defaultChromeFeatures

Review of attachment 8341125 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Note that no app should ever run in the parent process.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/f0cba15254a7

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f0cba15254a7