945265 - Submitted apps are incomplete after Content Rating is added

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P1)

Description

[Iulian Timis]

Steps to reproduce:
1. Load Submit a New App page https://marketplace-dev.allizom.org/developers/submit/
2. Submit a free app
3. Add Content Rating certificate
4. Go to the Status page of the app.

Expected results:
App status is Pending Approval.

Actual results:
The app status is Incomplete. Also, "Please complete your app." link takes the user to the Edit Listing page and does not give a clear message why the app is incomplete. If we click the "Edit" button from the Content Rating page, and then Submit the actual ID and Code, "Oops!" page is displayed.

Notes/Issues:
Verified on FF28 (Win 7).
Screencast for this issue http://screencast.com/t/0FVIQl5YeQS

Comment 1

[Rob Hudson [:robhudson]]

I'm guessing these are related?
http://sentry.dmz.phx1.mozilla.com/addons/marketplace-dev/group/17228/

Comment 2

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/e25a2c8

Comment 3

[Iulian Timis]

The "Oops" page is no longer displayed after submitting the actual ID and Code, but the App remains incomplete after submission and Content Rating already set up. Only after we Edit and Submit the actual ID and Code for Content Rating, the app changes its state to Pending Approval.
Please see screencast http://screencast.com/t/xLN0GHOX

Comment 4

[Rob Hudson [:robhudson]]

It looks like possibly the pingback API isn't updating the app completion status.

Comment 5

[Kevin Ngo [:ngoke]]

Couldn't get to the bottom of this. Here's what I found:

- ContentRating has a post_save to update the app status.
- set_content_ratings calls ContentRating.safer_get_or_create, which calls the post_save.
- calling set_content_ratings in the shell updates the app's status, for a submitted app that hasn't yet gotten content rating.
- tests on the pingback API correctly update the status
- the actual pingback API sets the content ratings, but fails to update the status

Comment 6

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/zamboni/pull/1494/

Comment 7

[Iulian Timis]

Issue is still reproducing in https://marketplace-dev.allizom.org/developers/ on FF28 (Win 7).
See app https://marketplace-dev.allizom.org/developers/app/test-app-automatikb/status

Comment 8

[Kevin Ngo [:ngoke]]

Whoops, put the code in the wrong file.

https://github.com/mozilla/zamboni/commit/fc5c2f0aa9be1534b81e4bb19603ec698a233e80

Comment 9

[Kevin Ngo [:ngoke]]

The JS is refreshing the page, killing the connection, before the status is updated.

Comment 10

[Christopher Van Wiemeersch [:cvan]]

Can we please consider moving this out of the submission flow?

Comment 11

[Kevin Ngo [:ngoke]]

Well, it's not in the main submission flow. Just something that is required to be done afterwards. It sucks, but apps need to get a content rating to be approved. 

Maybe an alternative flow would to be require apps to have content rating to be listed, but not approved?

Comment 12

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/zamboni/pull/1532

Comment 13

[Iulian Timis]

Verified as fixed in https://marketplace-dev.allizom.org/developers/ on FF29 (Win 7).
Closing bug.

Comment 14

[Kevin Ngo [:ngoke]]

Thanks, Rob for the sleuthing.