Closed Bug 945305 Opened 11 years ago Closed 11 years ago

[e.me][bug] Wrong search parameters from helper

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Everything.me
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:-)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g -

People

(Reporter: ranbena, Assigned: evyatar)

Details

Attachments

(1 file)

Patch - redirect to github PR
46 bytes, text/x-github-pull-request
ranbena
: review+
Details | Review 
When clicking on an item from the helper (history, spelling correction, type change, refinement) the "feature" parameter sent to e.me API is missing a value.

This may influence the quality of results returned by the server.
Assignee: nobody → evyatar
Status: NEW → ASSIGNED
blocking-b2g: --- → koi?
Can you be more specific about the impact here?

        Attachment #8341580 -
        Flags: review?(ran)

        Attachment #8341580 -
        Flags: review?(ran) → review+

    
    

    
  
Evyatar, don't land this on master right now

    
    

    
  
We've concluded that minor bug fixes don't need to be sheriffed. So go ahead.

    
    

    
  
Not blocking, but as Ran mentioned can be landed in master.
blocking-b2g: koi? → -

    
    

    
  
landed on master
0e6ed996066649490bd3a3ff76ff340b2e640716

https://github.com/mozilla-b2g/gaia/commit/0e6ed996066649490bd3a3ff76ff340b2e640716
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: