945319 - Manually triggered builds shouldn't start "Windows 2012 x64 PGO"

Status: RESOLVED DUPLICATE of bug 1047166

(Release Engineering :: General, defect)

Description

[John Hopkins (:jhopkins)]

There was a day-old "Windows 2012 x64 PGO" job showing in the buildapi pending list and on mozilla-inbound tbpl for revision aa4d8931ec0e

Whatever is triggering that build (self-serve?) should not do it as the builder does not exist in buildbot.


Relevant IRC scrollback:

jhopkins: "Windows 2012 x64 PGO" is pending since yesterday  https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=aa4d8931ec0e
[12:28pm] RyanVM|sheriffduty: jhopkins: must have been a manually-triggered pgo run
[12:29pm] RyanVM|sheriffduty: it's OK to cancel
[12:29pm] RyanVM|sheriffduty: jhopkins: buildbot isn't smart enough to realize that we haven't run those in ages
[12:29pm] RyanVM|sheriffduty: or self-serve
[12:29pm] RyanVM|sheriffduty: or whatever determines which platforms a manually-triggered job runs on
[12:30pm] jhopkins: RyanVM|sheriffduty: are you saying that builder should go away?
[12:32pm] RyanVM|sheriffduty: jhopkins: AFAIK, it's gone (hence the perma-pending)
[12:32pm] RyanVM|sheriffduty: jhopkins: self-serve is trying to trigger it and buildbot doesn't know what to do with it

Comment 1

[Phil Ringnalda (:philor)]

See bug 857486 - self-serve determines what jobs amount to "trigger PGO" by looking for PGO jobs that have been triggered over the past two weeks, so since we're never going to go two weeks without manually triggering PGO on inbound, making it go away requires killing them from the db back at least two weeks. Which according to my reading of that bug, we didn't actually do for central, we just managed to go two weeks without a manual triggering.

Or we could just keep doing what we've been doing since... last spring? last winter? and manually cancel them when we notice them.

Comment 2

[John Hopkins (:jhopkins)]

mysql> select distinct(buildername) from buildrequests where buildername like '% mozilla-inbound pgo-build' and submitted_at > (UNIX_TIMESTAMP() - 14 * 24 * 3600);
+--------------------------------------------+
| buildername                                |
+--------------------------------------------+
| Linux mozilla-inbound pgo-build            |
| Linux x86-64 mozilla-inbound pgo-build     |
| WINNT 5.2 mozilla-inbound pgo-build        |
| WINNT 6.1 x86-64 mozilla-inbound pgo-build |
+--------------------------------------------+
4 rows in set (36.18 sec)

Comment 3

[John Hopkins (:jhopkins)]

The query above was created by referencing http://hg.mozilla.org/build/buildapi/file/fb74189ac7db/buildapi/scripts/selfserve-agent.py#l454