Closed
Bug 945330
Opened 11 years ago
Closed 10 years ago
Teach mozharness about MOZ_CONTENT_SANDBOX_REPORTER error messages
Categories
(Testing :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla29
People
(Reporter: jld, Assigned: jld)
References
Details
Attachments
(2 files)
1.83 KB,
patch
|
kang
:
review+
|
Details | Diff | Splinter Review |
1.09 KB,
patch
|
mozilla
:
review+
|
Details | Diff | Splinter Review |
This is probably a one-line change to mozharness, to recognize the message logged by an --enable-content-sandbox --enable-content-sandbox-reporter build when it performs a forbidden system call and exits. It might be worth rewording the message in the Gecko source first, to make it simpler to grep for and future-proof it against other types of sandboxing, since this isn't enabled in anything that runs on TBPL yet.
Assignee | ||
Comment 1•10 years ago
|
||
Gecko change to reword the sandbox message; also includes the full syscall argument list.
Attachment #8356979 -
Flags: review?(gdestuynder)
Assignee | ||
Comment 2•10 years ago
|
||
Match the logcat message from the accompanying Gecko patch. Untested, because I don't know how to test it.
Attachment #8356984 -
Flags: review?(aki)
Comment 3•10 years ago
|
||
Comment on attachment 8356984 [details] [diff] [review] bug945330-mozharness-sandboxmsg-hg0.diff Looks good, thanks!
Attachment #8356984 -
Flags: review?(aki) → review+
Attachment #8356979 -
Flags: review?(gdestuynder) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Checkin note: the patch with "mozharness" in the name is for mozharness, and the other one is for Gecko (b2g-inbound suggested).
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/0a3f3bfcc712 https://hg.mozilla.org/build/mozharness/rev/3fd82a3eeedf
Keywords: checkin-needed
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0a3f3bfcc712
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•