945348 - Oops page when approving an app b/c of IARC SET_STOREFRONT_DATA call.

Status: VERIFIED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P1)

Description

[Rob Hudson [:robhudson]]

When the XML contains unicode characters the base64 encoding fails.

Comment 1

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/b86d3f1 

To verify, ensure an app has rating descriptors that contain unicode characters then attempt to approve an app from the reviewer tools.

Comment 2

[Victor Carciu]

I was not able to find IARC descriptors with unicode characters. Can you please send me a more specific example? 
Thanks

Comment 3

[Rob Hudson [:robhudson]]

I believe if you assign the app the content ratings associated with: submission_id=146 and security_code=V0Z52J7 you'll get one with unicode descriptors (for USK or CLASSIND, I'm not sure which).

Comment 4

[Victor Carciu]

I am not asked for IARC rating anymore on Stage or -dev when trying to submit a new app. Can you please enable to rating for testing purposes?

Comment 5

[Rob Hudson [:robhudson]]

(In reply to Victor Carciu from comment #4)
> I am not asked for IARC rating anymore on Stage or -dev when trying to
> submit a new app. Can you please enable to rating for testing purposes?

I re-enabled it on -dev.

Comment 6

[Victor Carciu]

Rob, I am sorry but after adding the content rating from comment #3 , I am not able to see any unicode descriptors : http://screencast.com/t/Ghi9K44b

Comment 7

[Rob Hudson [:robhudson]]

(In reply to Victor Carciu from comment #6)
> Rob, I am sorry but after adding the content rating from comment #3 , I am
> not able to see any unicode descriptors : http://screencast.com/t/Ghi9K44b

Ok. They must only be stored/sent with unicode but displayed according to the user's language preferences. If that id/code worked then I'd say this bug is verified. Prior to the patch it would have caused a 500 server error.

Comment 8

[Victor Carciu]

Thank you Rob . Verified as fixed.