945376 - [B2G][Settings][Sound] Selecting "None" as an alert tone brings up a filetype error

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Screenshot

Description:
If user selects "None" as an alert ringtone in the Settings app, an error message appears stating, "The page at app://settings.gaiamobile.org says: The ringtone was not changed because the selected file can not be played on this phone."

Repro Steps:
1) Updated Buri to Build ID: 20131202004001
2) Open Settings app
3) Select "Sound" category
4) Press "Change" button under "Alerts"
5) Select "None"
6) Confirm by pressing "Done"

Actual:
Selecting "none" as an alert ringtone shows an error message.

Expected:
User does not see error message for any selected ringtone.

Environmental Variables
Device: Buri v 1.2 COM RIL
Build ID: 20131202004001
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/14868788d50e
Gaia: 075e60c878b0eca68fba9e00bc85cb6eac03578a
Platform Version: 26.0
RIL Version: 01.02.00.019.102 
Firmware Version: V1.2_US_20131115


Notes:
Repro frequency: 3/3, 100%
See attached: screenshots

Comment 1

[Brogan Zumwalt [Inactive]]

Attachment: Screenshot

Comment 2

[Jason Smith [:jsmith]]

Sounds like this is broken UI.

Does this reproduce on 1.1?

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

1.1 doesn't have the Alert feature as a changeable sound.  it's not applicable.

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

It's broken UI.

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Eric, Could you take a look at this please and send it to the appropriate person?

Comment 6

[Preeti Raghunath(:Preeti)]

Tim,

Please review from a settings perspective. Kindly reassign appropriately.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Should be caused by forward lock feature work from djf.

Comment 8

[Dietrich Ayala (:dietrich)]

David, please reassign if this isn't your bug. Thanks!

Comment 9

[David Flanagan [:djf]]

Almost certainly my bug. Not in my original patch, but caused by a followup patch I made to prevent broken ringtones from being set. Fix coming soon.

Comment 10

[David Flanagan [:djf]]

Attachment: link to patch on github

Arthur, could you review this koi+ patch please? I ask because you've touched settings/js/sound.js most recently.  The bulk of the patch is actually in apps/ringtones/js/pick.js, but there is not really a module or peer for that.

Comment 11

[David Flanagan [:djf]]

The patch I've just attached applies cleanly to 1.2, so uplift should be easy.

Comment 12

[David Flanagan [:djf]]

Comment on attachment 8343890 [details] [review]
link to patch on github

Switching the reviewer to Punam from the Media team since this is mostly a media bug not a settings app bug.

Comment 13

[David Flanagan [:djf]]

The patch is green on Travis, though I had to restart it a couple of times to get past transient failures in other tests.

Comment 14

[Punam Dahiya [:pdahiya]]

Comment on attachment 8343890 [details] [review]
link to patch on github

Thanks David, the patch looks good, and works in both v1.2 and v1.3. I am able to successfully set alert tones to None and System alert tones. For Ringtones, i am able to set ringtones from System Ringtones and Music. 

I am not able to test setting ringtones with locked content(as wifi is not connecting in hamachi v1.3 due to keyboard not showing up while typing password). Since this patch hasn't touched the locked content flow, giving r+ 

Option buttons are shifted to the left in v1.3, i will open a new bug for fixing that.

Comment 15

[David Flanagan [:djf]]

Landed on master: https://github.com/mozilla-b2g/gaia/commit/c03dc12de63f00ca9dadf3c17f3f133b696d7395

Comment 16

[David Flanagan [:djf]]

And uplifted to v1.2: https://github.com/mozilla-b2g/gaia/commit/f615ae7acb6731d191b3094e10e314bc28359bbb

Comment 17

[Punam Dahiya [:pdahiya]]

Created bug https://bugzilla.mozilla.org/show_bug.cgi?id=947472 for option button shift UI issue seen in 1.3