[B2G][Settings][Sound] Selecting "None" as an alert tone brings up a filetype error

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Brogan Zumwalt [Inactive], Assigned: djf)

Tracking

({regression})

unspecified
ARM
Gonk (Firefox OS)
regression

Firefox Tracking Flags

(blocking-b2g:koi+, b2g-v1.2 fixed)

Details

Attachments

(3 attachments)

(Reporter)

Description

4 years ago
Created attachment 8341207 [details]
Screenshot

Description:
If user selects "None" as an alert ringtone in the Settings app, an error message appears stating, "The page at app://settings.gaiamobile.org says: The ringtone was not changed because the selected file can not be played on this phone."

Repro Steps:
1) Updated Buri to Build ID: 20131202004001
2) Open Settings app
3) Select "Sound" category
4) Press "Change" button under "Alerts"
5) Select "None"
6) Confirm by pressing "Done"

Actual:
Selecting "none" as an alert ringtone shows an error message.

Expected:
User does not see error message for any selected ringtone.

Environmental Variables
Device: Buri v 1.2 COM RIL
Build ID: 20131202004001
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/14868788d50e
Gaia: 075e60c878b0eca68fba9e00bc85cb6eac03578a
Platform Version: 26.0
RIL Version: 01.02.00.019.102 
Firmware Version: V1.2_US_20131115


Notes:
Repro frequency: 3/3, 100%
See attached: screenshots
(Reporter)

Comment 1

4 years ago
Created attachment 8341208 [details]
Screenshot
Sounds like this is broken UI.

Does this reproduce on 1.1?
Keywords: qawanted
1.1 doesn't have the Alert feature as a changeable sound.  it's not applicable.
Eric, Could you take a look at this please and send it to the appropriate person?
blocking-b2g: --- → koi?
Flags: needinfo?(epang)

Updated

4 years ago
Keywords: qawanted
Tim,

Please review from a settings perspective. Kindly reassign appropriately.
blocking-b2g: koi? → koi+
Flags: needinfo?(timdream)
Should be caused by forward lock feature work from djf.
Flags: needinfo?(timdream)
Flags: needinfo?(epang)
Flags: needinfo?(dflanagan)
David, please reassign if this isn't your bug. Thanks!
Assignee: nobody → dflanagan
Keywords: regression
(Assignee)

Comment 9

4 years ago
Almost certainly my bug. Not in my original patch, but caused by a followup patch I made to prevent broken ringtones from being set. Fix coming soon.
Flags: needinfo?(dflanagan)
(Assignee)

Comment 10

4 years ago
Created attachment 8343890 [details] [review]
link to patch on github

Arthur, could you review this koi+ patch please? I ask because you've touched settings/js/sound.js most recently.  The bulk of the patch is actually in apps/ringtones/js/pick.js, but there is not really a module or peer for that.
Attachment #8343890 - Flags: review?(arthur.chen)
(Assignee)

Comment 11

4 years ago
The patch I've just attached applies cleanly to 1.2, so uplift should be easy.
(Assignee)

Comment 12

4 years ago
Comment on attachment 8343890 [details] [review]
link to patch on github

Switching the reviewer to Punam from the Media team since this is mostly a media bug not a settings app bug.
Attachment #8343890 - Flags: review?(arthur.chen) → review?(pdahiya)
(Assignee)

Comment 13

4 years ago
The patch is green on Travis, though I had to restart it a couple of times to get past transient failures in other tests.
Comment on attachment 8343890 [details] [review]
link to patch on github

Thanks David, the patch looks good, and works in both v1.2 and v1.3. I am able to successfully set alert tones to None and System alert tones. For Ringtones, i am able to set ringtones from System Ringtones and Music. 

I am not able to test setting ringtones with locked content(as wifi is not connecting in hamachi v1.3 due to keyboard not showing up while typing password). Since this patch hasn't touched the locked content flow, giving r+ 

Option buttons are shifted to the left in v1.3, i will open a new bug for fixing that.
Attachment #8343890 - Flags: review?(pdahiya) → review+
(Assignee)

Comment 15

4 years ago
Landed on master: https://github.com/mozilla-b2g/gaia/commit/c03dc12de63f00ca9dadf3c17f3f133b696d7395
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Comment 16

4 years ago
And uplifted to v1.2: https://github.com/mozilla-b2g/gaia/commit/f615ae7acb6731d191b3094e10e314bc28359bbb
status-b2g-v1.2: affected → fixed
Created bug https://bugzilla.mozilla.org/show_bug.cgi?id=947472 for option button shift UI issue seen in 1.3
You need to log in before you can comment on or make changes to this bug.