Closed Bug 945387 Opened 11 years ago Closed 11 years ago

Use mocha-json-proxy write to pass the data

Categories

(Firefox OS Graveyard :: General, defect, P2)

Product:
Firefox OS Graveyard
Component:
General
Platform:
x86_64
Linux
Type:
defect

Tracking

(b2g-v1.3T fixed)

Status:
RESOLVED FIXED
Milestone:
1.3 C1/1.4 S1(20dec)
Tracking Flags:
Tracking Status
b2g-v1.3T --- fixed

People

(Reporter: hub, Assigned: hub)

References

Details

(Whiteboard: [c=automation p=1 s= u=])

Attachments

(1 file)

PR
46 bytes, text/x-github-pull-request
julienw
: review+
Details | Review 
For bu 915156, following bug 944494, update the test to use the exported function.

Current change:

https://github.com/hfiguiere/gaia/commit/f6f6d14cd8cb52c63cef888275e1d7a83e0f712e
Assignee: nobody → hub
Status: NEW → ASSIGNED
Depends on: 915156, 944494
Whiteboard: [c=automation p=1 s= u=]
Priority: -- → P2
Attached file PR — 
I have taken into account your comments and tried to make the function name obvious.
Attachment #8343799 - Flags: review?(felash)
Can you explain in 2, 3 sentences what benefits this gives over the current situation?
This allow us to abstract the (simple) protocol and also to deal with OOP vs in process outside of our scripts. This will make the maintenance easier in the long term, and less likely to break.
Comment on attachment 8343799 [details] [review]
PR

I'm not saying I understand completely the purpose of this, but this doesn't break anything, so if you think it's needed, let's land this in.

r=me
Attachment #8343799 - Flags: review?(felash) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: