Closed Bug 945417 Opened 11 years ago Closed 11 years ago

DMD fails to compile due to string literal assignment

Categories

(Core :: DMD, defect)

Product:
Core
Component:
DMD
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 945131

People

(Reporter: diego, Assigned: diego)

Details

Attachments

(1 file)

patch
1.35 KB, patch
Details | Diff | Splinter Review 
When DMD is enabled in B2G it fails with this error:

/local/mnt/workspace/dwilson/b2g_ics_1.3/gecko/memory/replace/dmd/DMD.cpp:718: error: invalid conversion from 'const char*' to 'char*'

This was introduced in bug 819839. ARM gcc 4.4 does not allow string literals to be assigned to a non-const string. Making the string const seems to fix it.
Sadly, tbpl B2G builds disable DMD by default. Which is why it wasn't caught.
Attached patch patch — — Splinter Review 
Assignee: nobody → dwilson
Status: NEW → ASSIGNED

        Attachment #8341266 -
        Flags: review?(n.nethercote)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE

        Attachment #8341266 -
        Flags: review?(n.nethercote)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: