945435 - Firefox changed the way it handled role="presentation" breaking ATs

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Rich Schwerdtfeger]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:25.0) Gecko/20100101 Firefox/25.0 (Beta/Release)
Build ID: 20131112160018

Steps to reproduce:

Placed role="presentation" on a table. 


Actual results:

Text of cells were merged causing the cells content to merged into single text strings making the content unintelligible as the author clearly wanted the content separated.


Expected results:

separate generic accessibles were created for non-structural descendants ( the way it used to be).

Comment 2

[Rich Schwerdtfeger]

An action item was filed against the ARIA 1.1 Implementation guide to address better conveyance that content was meant for presentational or layout purposes and that we would coordinate this with AT vendors and the browser manufacturers. but this needs to get reverted back to the generic accessibles for the structural descendants that got merged.

Comment 3

[alexander :surkov (:asurkov)]

Here's w3c minutes: https://www.w3.org/2013/12/02-pf-minutes.html

Note, either way (i.e. having accessible for td or not) goes with the spec but having no generic accessibles for td is not friendly to some AT. 

In general I'm fine to have generic accessibles for td. The disadvantage is this complicates the tree creation logic even more. What I would like to see is to keep the presentation table hierarchy in whole but expose it as layout table ("layout" object attribute on table accessible).

Comment 4

[Trevor Saunders (:tbsaunde)]

> In general I'm fine to have generic accessibles for td. The disadvantage is
> this complicates the tree creation logic even more. What I would like to see

yeah, that seems kind of unpleasent

> is to keep the presentation table hierarchy in whole but expose it as layout
> table ("layout" object attribute on table accessible).

that seems pretty reasonable on first thought.

Comment 5

[alexander :surkov (:asurkov)]

Rich, can you please check if this build works for you http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-07a4587e101d/

Comment 6

[alexander :surkov (:asurkov)]

I need a confirmation this patch works before finish it

failed mochitests:
https://tbpl.mozilla.org/php/getParsedLog.php?id=31402536&tree=Try&full=1#error3
try server build: https://tbpl.mozilla.org/?tree=Try&rev=07a4587e101d

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to Trevor Saunders (:tbsaunde) from comment #4)

> > is to keep the presentation table hierarchy in whole but expose it as layout
> > table ("layout" object attribute on table accessible).
> 
> that seems pretty reasonable on first thought.

+1

Comment 8

[Rich Schwerdtfeger]

Hi Alex, we will try this out.

Comment 9

[Rich Schwerdtfeger]

I had Freedom Scientific the build in bug 945435 and it looks like it works correctly.
You have replaced the <td> elements with IAccessibles with role = IA2_ROLE_TEXTFRAME.
JAWS now puts the text on separate lines. 

Perfect.

Comment 10

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 11

[alexander :surkov (:asurkov)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/1218829391b2

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1218829391b2