945443 - Allow `appcache_path` for packaged apps

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Validation, defect)

Description

[Christopher Van Wiemeersch [:cvan]]

The validator tells me this:

    * `appcache_path` is not allowed for packaged apps.

http://f.cl.ly/items/1X0Z1L2B2E2E3I3w3i45/Screen%20Shot%202013-12-02%20at%201.57.32%20PM.png

But in my testing, an `appcache_path` defined in a packaged app manifest works just fine! Let's remove the error! =)

Comment 1

[Matt Basta [:basta]]

I think I'm going to downgrade it to a warning rather than removing it altogether. A few reasons:

- I'd asked Fabrice whether we should allow it back when we wrote the manifest validation magic and at the time he said no because he had no idea how or whether it would work. Apparently it does, but there's no information to suggest that it'll stay that way.
- If you're using an appcache and you're also a packaged app there's some legitimate questions about what the hell you're doing.

I'm also going to keep the error for privileged packaged apps since referencing most things from the appcache would violate the CSP.

Comment 2

[Matt Basta [:basta]]

"Over SSL, all resources in the manifest must respect the same-origin policy."

Does this apply to our use case? Will it blend?

Comment 3

[Christopher Van Wiemeersch [:cvan]]

I did some testing and it turns out the `appcache_path` gets respected only for hosted apps anyway. Doesn't work with `app://` (or `file:///` protocol). Thanks though.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

FYI removed: https://github.com/mozilla/fireplace/commit/d56ad60