Bug 938686 broke non-unified builds

RESOLVED FIXED in Firefox 28

Status

()

Core
Audio/Video
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla28
Points:
---

Firefox Tracking Flags

(firefox28 fixed)

Details

(Whiteboard: [qa-])

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
content/media/ogg/OpusParser.cpp:70:16: error: use of undeclared identifier 'LEUint16'

and

content/media/ogg/OpusParser.cpp:181:5: error: use of undeclared identifier 'mTags'
(which, actually comes from error: unknown type name 'nsTArray' and error: unknown type name 'nsCString')
(Assignee)

Comment 1

4 years ago
Created attachment 8341410 [details] [diff] [review]
Kill LE* functions in OggCodecState.cpp and use Endian.h functions instead

For whoever comes first.
Attachment #8341410 - Flags: review?(roc)
Attachment #8341410 - Flags: review?(kinetik)
(Assignee)

Updated

4 years ago
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
(Assignee)

Comment 2

4 years ago
Created attachment 8341411 [details] [diff] [review]
Add missing includes in OpusParser.h
Attachment #8341411 - Flags: review?(roc)
Attachment #8341411 - Flags: review?(kinetik)
Attachment #8341411 - Flags: review?(giles)
(Assignee)

Updated

4 years ago
Attachment #8341410 - Flags: review?(giles)
Attachment #8341410 - Flags: review?(kinetik) → review+
Attachment #8341411 - Flags: review?(kinetik) → review+
Comment on attachment 8341410 [details] [diff] [review]
Kill LE* functions in OggCodecState.cpp and use Endian.h functions instead

Review of attachment 8341410 [details] [diff] [review]:
-----------------------------------------------------------------

Matthew's review suffices.
Attachment #8341410 - Flags: review?(roc)
Attachment #8341410 - Flags: review?(giles)
Attachment #8341411 - Flags: review?(roc)
Attachment #8341411 - Flags: review?(giles)
https://hg.mozilla.org/mozilla-central/rev/f729bbb4cc7d
https://hg.mozilla.org/mozilla-central/rev/357c5de8547b
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
status-firefox28: --- → fixed
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.