945532 - Bug 938686 broke non-unified builds

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Mike Hommey [:glandium]]

content/media/ogg/OpusParser.cpp:70:16: error: use of undeclared identifier 'LEUint16'

and

content/media/ogg/OpusParser.cpp:181:5: error: use of undeclared identifier 'mTags'
(which, actually comes from error: unknown type name 'nsTArray' and error: unknown type name 'nsCString')

Comment 1

[Mike Hommey [:glandium]]

Attachment: Kill LE* functions in OggCodecState.cpp and use Endian.h functions instead

For whoever comes first.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Add missing includes in OpusParser.h

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8341410 [details] [diff] [review]
Kill LE* functions in OggCodecState.cpp and use Endian.h functions instead

Review of attachment 8341410 [details] [diff] [review]:
-----------------------------------------------------------------

Matthew's review suffices.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f729bbb4cc7d
https://hg.mozilla.org/mozilla-central/rev/357c5de8547b