Selected tab has wrong text-shadow with lightweight themes applied

RESOLVED FIXED in Firefox 29

Status

()

defect
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: bram, Assigned: dao)

Tracking

Trunk
Firefox 29
All
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Australis:P4][good first verify])

Attachments

(2 attachments)

Reporter

Description

6 years ago
The problem here is twofold:

1. When text is dark (top image), the shadow applied to the text of selected tab is also dark, leading to the text looking like it’s been “doubled up”. We can either apply a light-colored shadow or disable shadow entirely. (See bug 549346).

2. When text is light (bottom image), the shadow applied to the text in the chrome is inconsistent. Text shadows on inactive tabs and bookmarks toolbar texts have more blur, when compared to the shadow on the active tab. We should pick one value and apply it consistently throughout the chrome.
Assignee

Comment 1

6 years ago
Where are the top and bottom images?
Assignee

Updated

6 years ago
Component: Themes → Theme
No longer depends on: 549346
Product: Toolkit → Firefox
Summary: Lightweight themes have inconsistent text shadow values → Selected tab has wrong text-shadow with lightweight themes applied
Assignee

Updated

6 years ago
Assignee: nobody → dao
Assignee

Comment 3

5 years ago
Posted patch patchSplinter Review
Attachment #8364337 - Flags: review?(MattN+bmo)
Assignee

Updated

5 years ago
Assignee

Updated

5 years ago
Whiteboard: [Australis:P4]
Assignee

Updated

5 years ago
Blocks: 963083
(In reply to Bram Pitoyo [:bram] from comment #0)
> The problem here is twofold:
> 
> 1. When text is dark (top image), the shadow applied to the text of selected
> tab is also dark, leading to the text looking like it’s been “doubled up”.
> We can either apply a light-colored shadow or disable shadow entirely. (See
> bug 549346).

I can't reproduce this behaviour. The dark text colour should lead to a light highlight (and it does for me). Do you know what theme was used in the screenshot?

> 2. When text is light (bottom image), the shadow applied to the text in the
> chrome is inconsistent. Text shadows on inactive tabs and bookmarks toolbar
> texts have more blur, when compared to the shadow on the active tab. We
> should pick one value and apply it consistently throughout the chrome.

Dão, were you planning on handling this in a separate bug or is this no longer true?
Status: NEW → ASSIGNED
Flags: needinfo?(bram)
Hardware: x86 → All
Assignee

Comment 5

5 years ago
(In reply to Matthew N. [:MattN] from comment #4)
> > 2. When text is light (bottom image), the shadow applied to the text in the
> > chrome is inconsistent. Text shadows on inactive tabs and bookmarks toolbar
> > texts have more blur, when compared to the shadow on the active tab. We
> > should pick one value and apply it consistently throughout the chrome.
> 
> Dão, were you planning on handling this in a separate bug or is this no
> longer true?

My patch should fix that? I.e. it should make the selected tab inherit the text-shadow defined by the lightweight theme styles instead of using its own shadow. Unfortunately I can't currently test this on OS X.
Reporter

Comment 6

5 years ago
> I can't reproduce this behaviour. The dark text colour should lead to a
> light highlight (and it does for me). Do you know what theme was used in the
> screenshot?

I was testing using the Japanese Tattoo theme, but the behavior shows up on other light-colored themes, as well.

Japanese Tattoo
https://addons.mozilla.org/en-US/firefox/addon/japanese-tattoo/

https://addons.mozilla.org/en-US/firefox/addon/little-flowers/
https://addons.mozilla.org/en-US/firefox/addon/red-ladybug/
https://addons.mozilla.org/en-US/firefox/addon/eco-theme/
https://addons.mozilla.org/en-US/firefox/addon/firefox-b/
https://addons.mozilla.org/en-US/firefox/addon/live-with-music/
https://addons.mozilla.org/en-US/firefox/addon/litefox/

Ideally, when a light theme is chosen, we’d either apply a light-colored shadow or disable it.
Flags: needinfo?(bram)
Assignee

Updated

5 years ago
Flags: needinfo?(MattN+bmo)
Assignee

Updated

5 years ago
Attachment #8364337 - Flags: review?(MattN+bmo)
Flags: needinfo?(MattN+bmo)
Comment on attachment 8364337 [details] [diff] [review]
patch

Review of attachment 8364337 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay. I had a travel and PTO day at the beginning of the week.
Attachment #8364337 - Flags: review?(MattN+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/796764d8c4bf
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29

Updated

5 years ago
Whiteboard: [Australis:P4] → [Australis:P4][good first verify]
You need to log in before you can comment on or make changes to this bug.