945547 - Selected tab has wrong text-shadow with lightweight themes applied

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Bram Pitoyo [:bram]]

The problem here is twofold:

1. When text is dark (top image), the shadow applied to the text of selected tab is also dark, leading to the text looking like it’s been “doubled up”. We can either apply a light-colored shadow or disable shadow entirely. (See bug 549346).

2. When text is light (bottom image), the shadow applied to the text in the chrome is inconsistent. Text shadows on inactive tabs and bookmarks toolbar texts have more blur, when compared to the shadow on the active tab. We should pick one value and apply it consistently throughout the chrome.

Comment 1

[Dão Gottwald [:dao]]

Where are the top and bottom images?

Comment 2

[Bram Pitoyo [:bram]]

Attachment: lightweight theme chrome, light and dark text color

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

Comment 4

[Matthew N. [:MattN]]

(In reply to Bram Pitoyo [:bram] from comment #0)
> The problem here is twofold:
> 
> 1. When text is dark (top image), the shadow applied to the text of selected
> tab is also dark, leading to the text looking like it’s been “doubled up”.
> We can either apply a light-colored shadow or disable shadow entirely. (See
> bug 549346).

I can't reproduce this behaviour. The dark text colour should lead to a light highlight (and it does for me). Do you know what theme was used in the screenshot?

> 2. When text is light (bottom image), the shadow applied to the text in the
> chrome is inconsistent. Text shadows on inactive tabs and bookmarks toolbar
> texts have more blur, when compared to the shadow on the active tab. We
> should pick one value and apply it consistently throughout the chrome.

Dão, were you planning on handling this in a separate bug or is this no longer true?

Comment 5

[Dão Gottwald [:dao]]

(In reply to Matthew N. [:MattN] from comment #4)
> > 2. When text is light (bottom image), the shadow applied to the text in the
> > chrome is inconsistent. Text shadows on inactive tabs and bookmarks toolbar
> > texts have more blur, when compared to the shadow on the active tab. We
> > should pick one value and apply it consistently throughout the chrome.
> 
> Dão, were you planning on handling this in a separate bug or is this no
> longer true?

My patch should fix that? I.e. it should make the selected tab inherit the text-shadow defined by the lightweight theme styles instead of using its own shadow. Unfortunately I can't currently test this on OS X.

Comment 6

[Bram Pitoyo [:bram]]

> I can't reproduce this behaviour. The dark text colour should lead to a
> light highlight (and it does for me). Do you know what theme was used in the
> screenshot?

I was testing using the Japanese Tattoo theme, but the behavior shows up on other light-colored themes, as well.

Japanese Tattoo
https://addons.mozilla.org/en-US/firefox/addon/japanese-tattoo/

https://addons.mozilla.org/en-US/firefox/addon/little-flowers/
https://addons.mozilla.org/en-US/firefox/addon/red-ladybug/
https://addons.mozilla.org/en-US/firefox/addon/eco-theme/
https://addons.mozilla.org/en-US/firefox/addon/firefox-b/
https://addons.mozilla.org/en-US/firefox/addon/live-with-music/
https://addons.mozilla.org/en-US/firefox/addon/litefox/

Ideally, when a light theme is chosen, we’d either apply a light-colored shadow or disable it.

Comment 7

[Matthew N. [:MattN]]

Comment on attachment 8364337 [details] [diff] [review]
patch

Review of attachment 8364337 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay. I had a travel and PTO day at the beginning of the week.

Comment 8

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/796764d8c4bf

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/796764d8c4bf