945563 - HeapAPI.h:51:23: error: C++ requires a type specifier for all declarations when building with 8 unified sources instead of 16

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Mike Hommey [:glandium]]

Open python/mozbuild/mozbuild/backend/recursivemake.py, search for files_per_unification, replace its value (16) with 8.

This is the error you can get then:

../../dist/include/js/HeapAPI.h:51:23: error: C++ requires a type specifier for all declarations
static const uint32_t BLACK = 0;
                      ^~~~~
layout/base/nsCSSColorUtils.cpp:35:20: note: expanded from macro 'BLACK'
#define BLACK      NS_RGB(0, 0, 0)
                   ^~~~~~~~~~~~~~~

Interestingly, nsCSSColorUtils.cpp doesn't even use BLACK.

Comment 1

[Mike Hommey [:glandium]]

There are two ways to fix this:
- Remove the unused macro
- Replace macros with static const variables.

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to Mike Hommey [:glandium] from comment #1)
> There are two ways to fix this:
> - Remove the unused macro
> - Replace macros with static const variables.

We should definitely do the former (for BLACK and WHITE, both of which are unused).

The latter may be worthwhile too, but isn't necessary to fix this bug.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Remove unused macros in nsCSSColorUtils.cpp (BLACK, WHITE and LIGHT_FACTOR)

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a0b60b2d12f0