B2G RIL: Add test cases for 'icc-stkcomand' system message.

RESOLVED DUPLICATE of bug 1123624

Status

Firefox OS
RIL
RESOLVED DUPLICATE of bug 1123624
4 years ago
3 years ago

People

(Reporter: edgar, Assigned: edgar)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(tracking-b2g:backlog)

Details

Attachments

(3 attachments, 4 obsolete attachments)

(Assignee)

Description

4 years ago
Created attachment 8341474 [details] [diff] [review]
Patch

+++ This bug was initially created as a follow-up of Bug #942096 +++

I am trying to write a marionette test for 'icc-stkcommand' system message, but it is failed in try server (It can pass if we run single test).

failed try result: https://tbpl.mozilla.org/?tree=Try&rev=b3a3ed2a34dd

raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
TEST-UNEXPECTED-FAIL | test_stk_proactive_command.js | ScriptTimeoutException: timed out
.....

Stk related marionette tests are all time out due to doesn't receive 'icc-stkcommand'.
(Assignee)

Comment 1

4 years ago
After did some tests, I found if we don't run below tests, system message can work as expected in marionette testing.
- $GECKO_DIR/testing/marionette/client/marionette/tests/unit/unit-tests.ini
- $GECKO_DIR/dom/network/tests/marionette/manifest.ini

Have no idea yet.

Comment 2

4 years ago
Put it in backlog.
blocking-b2g: --- → backlog
(Assignee)

Updated

3 years ago
Blocks: 791161
(Assignee)

Comment 3

3 years ago
No stk test failure in try, https://tbpl.mozilla.org/?tree=Try&rev=3a0378d7b4bb
Looks like the problem I met in comment #1 and comment #2 is no longer existed?
Let's see if we can put this test online. :)
Assignee: nobody → echen
(Assignee)

Comment 4

3 years ago
Created attachment 8518684 [details] [diff] [review]
Part 1: Rewrite test_stk_* with Promise, v1
Attachment #8341474 - Attachment is obsolete: true
(Assignee)

Comment 5

3 years ago
Created attachment 8518686 [details] [diff] [review]
Part 2: split test_stk_proactive_command.js into localInfo and timerManagement, v1
(Assignee)

Comment 6

3 years ago
Created attachment 8518687 [details] [diff] [review]
Part 3: Add tests for stk system message, v1
(Assignee)

Comment 7

3 years ago
I guess I need to do rebase for bug 1091454, will send review request then.
(Assignee)

Updated

3 years ago
Blocks: 1087968
(Assignee)

Comment 8

3 years ago
Try looks good: https://tbpl.mozilla.org/?tree=Try&rev=88ddf382fff0 \o/
(Assignee)

Comment 9

3 years ago
Created attachment 8530235 [details] [diff] [review]
Part 1: Rewrite test_stk_* with Promise, v2

rebase
Attachment #8518684 - Attachment is obsolete: true
(Assignee)

Comment 10

3 years ago
Created attachment 8530236 [details] [diff] [review]
Part 2: split test_stk_proactive_command.js into localInfo and timerManagement, v2

rebase
Attachment #8518686 - Attachment is obsolete: true
(Assignee)

Comment 11

3 years ago
Created attachment 8530237 [details] [diff] [review]
Part 3: Add tests for stk system message, v2

rebase
Attachment #8518687 - Attachment is obsolete: true
(Assignee)

Comment 12

3 years ago
Due to bug 1123624, I decide to rewrite stk test cases with Promise in bug 1087968.
No longer blocks: 1087968
(Assignee)

Comment 13

3 years ago
Will add test cases for stk system message in bug 1123624.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1123624
blocking-b2g: backlog → ---
tracking-b2g: --- → backlog
You need to log in before you can comment on or make changes to this bug.