Closed Bug 945601 Opened 8 years ago Closed 8 years ago

[LockScreen] The acceleration mode of LockScreen should be more smooth

Categories

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v1.3 fixed)

RESOLVED FIXED
Tracking Status
b2g-v1.3 --- fixed

People

(Reporter: gweng, Assigned: gweng)

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
timdream
: review+
Details | Review
Currently it use addition to accelerate the sliding while dragging. It should be more smooth to use a curve instead of.
Assignee: nobody → gweng
I've found the

    y = x^1.2

may be a good curve.
Attached file Patch
May need UX's opinion. I send the patch to show the code differences first.
Attachment #8347855 - Flags: review?(timdream)
Finally we decide to use x^1.02.
Comment on attachment 8347855 [details] [review]
Patch

I found a possible way to adjust the accelerating factor for the left side, I would make some modifications and set the review again.
Attachment #8347855 - Flags: review?(timdream)
Comment on attachment 8347855 [details] [review]
Patch

Set the review flag again.
Attachment #8347855 - Flags: review?(timdream)
Comment on attachment 8347855 [details] [review]
Patch

Glad to see there are more red than green in the patch!
Attachment #8347855 - Flags: review?(timdream) → review+
Travis still stuck at marionette.js, but it seems unrelated according to previous result.
master: https://github.com/mozilla-b2g/gaia/commit/0da6efc6bcd4a40b6e4378b15f9aacfb6f5921a2
I've forgot to tag this as resolved...
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
This bug should be checked in to let related bug (like Bug 935148) not conflicts with this.

And Tim grant this as approval-gaia-v1.3+ offline (I just asked him, and he approved that).
You need to log in before you can comment on or make changes to this bug.