945607 - Spell Checker does not replace the wrong spelling with the right one

Status: RESOLVED WORKSFORME

(Core :: Spelling checker, defect)

Description

[Aniruddha]

Attachment: test.html

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20100101 Firefox/25.0 (Beta/Release)
Build ID: 20131112160018

Steps to reproduce:

Firefox 25.0.1
1. Open the attached html file
2. Right click on the incorrect spelling and try to correct it.


Actual results:

The wrong spelling does not get replaced with the right spelling. There is the following error in the JavaScript console:

[12:18:15.542] NS_ERROR_INVALID_POINTER: Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIInlineSpellChecker.replaceWord] @ resource://gre/modules/InlineSpellChecker.jsm:273


NOTE: It works fine if I perform the entire operation without bringing the mouse pointer anywhere near the text area. i.e. Using the keyboard 
1. Tab key to tab into the textarea
2. Key to the left of the Ctrl key to bring up the context/popup menu
3. Up-down navigation keys to scroll through the spelling suggestions 
4. Enter key to select one of the suggestions. 
Then it works


Expected results:

The wrong spelling should get replaced with the right spelling

Comment 1

[Alice0775 White]

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/3589bf459f85
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0a1) Gecko/20110422 Firefox/6.0a1 ID:20110422183205
Bad:
http://hg.mozilla.org/mozilla-central/rev/b7b5af018848
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0a1) Gecko/20110422 Firefox/6.0a1 ID:20110422184500
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3589bf459f85&tochange=b7b5af018848

Suspected :Bug 197686

Comment 2

[Boris Zbarsky [:bzbarsky]]

Presumably the same thing has always been broken in standards mode?

And even more presumably the issue is that the reframe caused by the hover style confuses the spellechecker UI somehow....

Comment 3

[(no longer active)]

(In reply to Boris Zbarsky [:bz] from comment #2)
> Presumably the same thing has always been broken in standards mode?
> 
> And even more presumably the issue is that the reframe caused by the hover
> style confuses the spellechecker UI somehow....

Yes, that makes sense.

Aniruddha, is this issue breaking your website?  Can you please let me know what the impact of this bug is?

Thanks!

Comment 4

[Aniruddha]

Well, it is a usability issue, not a very high impact, but nice to have a fix.

Comment 5

[Aniruddha]

Any updates on this? When can we expect a fix?

Comment 6

[(no longer active)]

Attachment: WIP

This patch fixes some of the mozInlineSpellChecker re-initialization bits so that it gets properly attached to the editor object, etc.  This eliminates the null pointer errors in the stderr spew but still doesn't fix this test case.  I don't have more time to look into why right now.

Comment 7

[Kagami Rosylight [:saschanaz] (they/them)]

Seems to be working now, closing.