Closed Bug 945611 Opened 8 years ago Closed 8 years ago

Run marionette tests for a specific app.

Categories

(Firefox OS Graveyard :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: evanxd, Assigned: evanxd)

Details

Attachments

(2 files)

46 bytes, text/x-github-pull-request
yurenju
: review+
Details | Review
46 bytes, text/x-github-pull-request
yurenju
: review+
Details | Review
We could run marionette test for specified app with `make test-integration APP=[app-name]`.
For example, we could run marionette test of Calendar App with `make test-integration APP=calendar`.
Summary: Run marionette test for specified app. → Run marionette tests for a specific app.
Attached file Pull request
Hi Yuren,

Please help me to review the patch.
Thanks.
Attachment #8342243 - Flags: review?(yurenju.mozilla)
Comment on attachment 8342243 [details] [review]
Pull request

Hi Evan,

looks good, r=yurenju! please don't forget to remove |make| stuffs in gaia-marionette and wait travis-ci running all tests again.

thank you.
Attachment #8342243 - Flags: review?(yurenju.mozilla) → review+
Hi Yuren, 

Thanks for your review.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
We revert the patch because we would not like to remove the b2g download function from the gaia-marionette command. https://github.com/mozilla-b2g/gaia/commit/9cca0920cabdcc55c748880e2818c986a0dbf51f
Attached file Pull request v2
Hi Yuren,

Please help me to review the patch.
Thanks.
Attachment #8343493 - Flags: review?(yurenju.mozilla)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8343493 [details] [review]
Pull request v2

it would be great to handle all dependency in makefile instead of execute |make| in gaia-marionette, but I also agree current way is better for user only care about gaia-marionette and they don't need to execute |make| by themself before using gaia-marionette, so r+ again.
Attachment #8343493 - Flags: review?(yurenju.mozilla) → review+
We already had follow up bug https://bugzilla.mozilla.org/show_bug.cgi?id=947066 for gaia-marionette things.
We merge the patch with the error https://travis-ci.org/mozilla-b2g/gaia/jobs/15020961 because the error is not related with the patch.
master: https://github.com/mozilla-b2g/gaia/commit/2cb43b6f4f7054abae611e1f1ffe6f10f1b029bc
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.