945617 - The notification bar for hidden plugins shows up when blocking non-hidden plugins

Status: RESOLVED WONTFIX

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Paul Silaghi, QA [:pauly]]

STR:
1. Have Flash on 'Always activate'
2. Open a youtube video
3. Block the plugin from the CTP doorhanger
AR: The notification bar for hidden plugins shows up, even if there is no hidden plugin

Regression of bug 941714.

Comment 1

[Georg Fritzsche [:gfritzsche]]

Attachment: Partial fix

In this case we hit a test where the plugin has no overlay:
http://hg.mozilla.org/mozilla-central/annotate/85196889c598/browser/base/content/browser-plugins.js#l928
... this *would* mean we show the bar for a short time, but when "PluginBindingAttached" is fired, we end up arond here with aShowNow=false:
http://hg.mozilla.org/mozilla-central/annotate/85196889c598/browser/base/content/browser-plugins.js#l854
... so we're not updating anything. This is changed by this partial fix.

This still leaves the bar showing up for a bit though. It seems like we should move the check from bug 941714 to the CTP-event handling code, but that currently doesn't cover every situation (e.g. "block"->"allownow"->"block" doesn't trigger another event like "PluginBindingAttached").

Comment 2

[BMO Automation]

Resolving as wont fix, plugin support deprecated in Firefox 85.