945640 - [bluedroid HFP] Volume UI doesn't pop up when bluetooth headset adjusts volume during call

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Ben Tian (inactive)]

Volume UI doesn't pop up when bluetooth headset adjusts volume during call. The reason is that Bluedroid HFP manager fails to notify gaia as the notification code doesn't run on main thread.

Comment 1

[Ben Tian (inactive)]

Attachment: Patch 1 (v1): Notfiy SCO volume change on main thread

Comment 2

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 8341609 [details] [diff] [review]
Patch 1 (v1): Notfiy SCO volume change on main thread

Review of attachment 8341609 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit addressed. Thanks.

::: dom/bluetooth/bluedroid/BluetoothHfpManager.cpp
@@ +279,5 @@
>          break;
> +      case MainThreadTaskCmd::NOTIFY_SCO_VOLUME_CHANGED:
> +        {
> +          nsCOMPtr<nsIObserverService> os =
> +            mozilla::services::GetObserverService();

Please check if os has value. (so please assist with revising bluez/BluetoothHfpManager.cpp as well)

Comment 3

[Ben Tian (inactive)]

Attachment: [final] Patch 1: Notfiy SCO volume change on main thread, r=echou

Changes:
- ensure variable 'os' in comment 2 not nullptr for both bluez and bluedroid.
- replace NS_ASSERTION with if-statement in bluez/BluetoothHfpManager.cpp

Comment 4

[Ben Tian (inactive)]

try server: https://tbpl.mozilla.org/?tree=Try&rev=a364656cf7e6

Comment 5

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/b2g-inbound/rev/98b5726efb4a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/98b5726efb4a