Closed
Bug 945697
Opened 11 years ago
Closed 11 years ago
Responsive Mode gets closed when ESC is used in the varilable view, in the rule view and in the variable view
Categories
(DevTools :: Responsive Design Mode, defect)
Tracking
(firefox28 fixed, firefox29 fixed)
RESOLVED
FIXED
Firefox 29
People
(Reporter: paul, Assigned: bgrins)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
5.70 KB,
patch
|
paul
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
(regression caused by bug 942946) - in responsive mode - open the variable view (from webconsole) or markup view, or rule view - edit a field - press ESC to close the inplace editor - responsive mode is closed instead of closing the inplace editor
Reporter | ||
Comment 1•11 years ago
|
||
This blocks all the Gaia developers that use the DEBUG profile extensions (based on the responsive mode)
Assignee | ||
Comment 3•11 years ago
|
||
I'll take a look at it
Assignee: nobody → bgrinstead
Flags: needinfo?(bgrinstead)
Assignee | ||
Comment 4•11 years ago
|
||
Go back to bubbling for esc keypress, but check if responsive mode is on from split console and ignore the event from toolbox level if so. Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=e43e13dffa6b
Attachment #8344664 -
Flags: review?(paul)
Reporter | ||
Updated•11 years ago
|
Attachment #8344664 -
Flags: review?(paul) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0337f5512e0d
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 8344664 [details] [diff] [review] responsive-esc.patch [Approval Request Comment] Bug caused by (feature/regressing bug #): 942946 User impact if declined: When using developer tools with responsive view enabled, the escape key will always close responsive view Testing completed (on m-c, etc.): Yes, been on m-c since 12/10 Risk to taking this patch (and alternatives if risky): Low risk, limited to keyboard shortcuts in developer tools String or IDL/UUID changes made by this patch:
Attachment #8344664 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Attachment #8344664 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 8•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/2d0770719fdf
status-firefox28:
--- → fixed
status-firefox29:
--- → fixed
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•