945697 - Responsive Mode gets closed when ESC is used in the varilable view, in the rule view and in the variable view

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, defect)

Description

[Paul Rouget [:paul]]

(regression caused by bug 942946)

- in responsive mode
- open the variable view (from webconsole) or markup view, or rule view
- edit a field
- press ESC to close the inplace editor
- responsive mode is closed instead of closing the inplace editor

Comment 1

[Paul Rouget [:paul]]

This blocks all the Gaia developers that use the DEBUG profile extensions (based on the responsive mode)

Comment 2

[Paul Rouget [:paul]]

Brian, halp!

Comment 3

[Brian Grinstead [:bgrins]]

I'll take a look at it

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: responsive-esc.patch

Go back to bubbling for esc keypress, but check if responsive mode is on from split console and ignore the event from toolbox level if so.  Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=e43e13dffa6b

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/0337f5512e0d

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0337f5512e0d

Comment 7

[Brian Grinstead [:bgrins]]

Comment on attachment 8344664 [details] [diff] [review]
responsive-esc.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 942946
User impact if declined: When using developer tools with responsive view enabled, the escape key will always close responsive view
Testing completed (on m-c, etc.): Yes, been on m-c since 12/10
Risk to taking this patch (and alternatives if risky): Low risk, limited to keyboard shortcuts in developer tools
String or IDL/UUID changes made by this patch:

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2d0770719fdf