945726 - Windows desktop B2G builds are higher priority than Firefox builds

Status: RESOLVED FIXED

Description

[Ryan VanderMeulen [:RyanVM]]

We had a situation this morning where Windows desktop Firefox builds were lagging by over 3 hours on b2g-inbound while the Desktop B2G builds were all humming along just fine. bhearsum tells me that this is due to how B2G builds are prioritized.

Desktop Firefox builds actually run tests and should always take priority over the B2G builds which are basically run just to make sure they don't break.

Comment 1

[Ben Hearsum (:bhearsum)]

I traced this back to https://bugzilla.mozilla.org/show_bug.cgi?id=823642#c0. I have a feeling this was added during a b2g work week. We should probably make them at least equal priority at this point. Catlee?

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Can we differentiate between tests and builds for these purposes?

Comment 3

[Ben Hearsum (:bhearsum)]

Absolutely!

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Given that B2G builds and tests run in AWS and capacity is rarely an issue, I don't think we really need to, though. I think we can just kill the special case and call it a day.

Comment 5

[Ben Hearsum (:bhearsum)]

Windows b2g builds don't run in AWS though...does that make a difference to you? We could adjust priorities on per-builder type basis, too.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Non-AWS B2G desktop builds are run at this point only to make sure they still build. The platforms that actually run tests are AWS.

Comment 7

[Chris AtLee [:catlee]]

equal priority sounds fine to me

Comment 8

[Ben Hearsum (:bhearsum)]

Created attachment 8341841 [details] [diff] [review]
remove b2g special case + fix for bug 945724

I think this addresses this bug and bug 945724.

Comment 10

[John Hopkins (:jhopkins)]

in production

Comment 11

[Ben Hearsum (:bhearsum)]

Hopefully this will help.