Closed Bug 945734 Opened 8 years ago Closed 5 years ago

Use "invalid argument" status for wrong screen orientation

Categories

(Testing :: Marionette, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(firefox48 fixed, firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: ato, Assigned: ato)

References

(Blocks 1 open bug)

Details

(Keywords: pi-marionette-server)

Attachments

(1 file)

To distinguish between the general fallback WebDriverException/
MarionetteException when the user sends an invalid screen orientation
to setScreenOrientation, we should use a new status code “invalid
argument”.

See the W3C issue tracker for the discussion:

    https://www.w3.org/Bugs/Public/show_bug.cgi?id=23950
Attachment #8750783 - Flags: review?(dburns) → review+
Comment on attachment 8750783 [details]
MozReview Request: Bug 945734 - Correct argument error in GeckoDriver#setScreenOrientation; r?automatedtester

https://reviewboard.mozilla.org/r/51623/#review48521
Comment on attachment 8750783 [details]
MozReview Request: Bug 945734 - Correct argument error in GeckoDriver#setScreenOrientation; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/51623/diff/1-2/
Assignee: nobody → ato
https://hg.mozilla.org/mozilla-central/rev/f2815dd0ea7e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.