Closed
Bug 945734
Opened 10 years ago
Closed 8 years ago
Use "invalid argument" status for wrong screen orientation
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
mozilla49
People
(Reporter: ato, Assigned: ato)
References
(Blocks 1 open bug)
Details
(Keywords: pi-marionette-server)
Attachments
(1 file)
To distinguish between the general fallback WebDriverException/ MarionetteException when the user sends an invalid screen orientation to setScreenOrientation, we should use a new status code “invalid argument”. See the W3C issue tracker for the discussion: https://www.w3.org/Bugs/Public/show_bug.cgi?id=23950
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/51623/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/51623/
Attachment #8750783 -
Flags: review?(dburns)
Updated•8 years ago
|
Attachment #8750783 -
Flags: review?(dburns) → review+
Comment 2•8 years ago
|
||
Comment on attachment 8750783 [details] MozReview Request: Bug 945734 - Correct argument error in GeckoDriver#setScreenOrientation; r?automatedtester https://reviewboard.mozilla.org/r/51623/#review48521
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8750783 [details] MozReview Request: Bug 945734 - Correct argument error in GeckoDriver#setScreenOrientation; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/51623/diff/1-2/
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → ato
Keywords: ateam-marionette-server
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f2815dd0ea7e
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Comment 6•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/0515fd909bc8
status-firefox48:
--- → fixed
Comment 7•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/0515fd909bc8
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•