Closed
Bug 945767
Opened 11 years ago
Closed 11 years ago
talos isn't copying breakpad binaries to installation
Categories
(Testing :: Talos, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
Attachments
(1 file)
353 bytes,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
manifest.in for talos got accidentally deleted and added back incorrectly.
Assignee | ||
Comment 1•11 years ago
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8341779 [details] [diff] [review] * instead of *.* (1.0) lgtm
Attachment #8341779 -
Flags: review?(jhammel) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/build/talos/rev/2bcf422011d1
Comment 4•11 years ago
|
||
This could apparently be a cause of bug 945969. Does this need to be separately pushed to production, or should the push from comment 3 resolve it?
Comment 5•11 years ago
|
||
(In reply to :Gavin Sharp (email gavin@gavinsharp.com) from comment #4) > This could apparently be a cause of bug 945969. Does this need to be > separately pushed to production, or should the push from comment 3 resolve > it? talos.json on m-c needs to be updated for this to take effect. See bug 943899 for an example.
Assignee | ||
Comment 6•11 years ago
|
||
I have tested it on try and will land it in the morning: https://tbpl.mozilla.org/?tree=Try&rev=444058e8e9f8
Comment 7•11 years ago
|
||
Thanks, is there a bug on file to make sure this gets reported as a failure on TBPL in the future?
Assignee | ||
Comment 9•11 years ago
|
||
unfortunately this didn't cause any failures on tbpl :( that is disturbing, we can use bug 945767
Flags: needinfo?(jmaher)
Comment 10•11 years ago
|
||
(In reply to Joel Maher (:jmaher) from comment #9) > unfortunately this didn't cause any failures on tbpl :( that is disturbing, > we can use bug 945767 That's this bug. Did you mean another?
Assignee | ||
Comment 11•11 years ago
|
||
lets use bug 938664 for regression purposes.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•