Closed Bug 945768 Opened 6 years ago Closed 6 years ago

[Shared] Follow up: Update shared action icons

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: epang, Assigned: pivanov)

References

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, jian)

Attachments

(2 files, 1 obsolete file)

46 bytes, text/x-github-pull-request
epang
: review+
Details | Review
13.07 KB, application/x-zip-compressed
Details
Attached file shared icons.zip (obsolete) —
Hi Pavel, Przemek and I noticed that some icons were not centered.  I re-exported the assets, can you overwrite again?  thanks!
Attached file patch for Gaia/master
Hey Eric,
I notice that all @1.5x images have 46px width instead 45px can we fix this?
Attachment #8341823 - Flags: feedback?(epang)
Attached file shared 2.zip
sorry, I've updated the icons.  Thanks!
Attachment #8341762 - Attachment is obsolete: true
Flags: needinfo?(pivanov)
Attachment #8341823 - Flags: feedback?(epang) → review?(epang)
Comment on attachment 8341823 [details] [review]
patch for Gaia/master

Looks good, thanks Pavel!  Let's land this.
Attachment #8341823 - Flags: review?(epang) → review+
Landed in master:
https://github.com/mozilla-b2g/gaia/commit/14c938e53391a945e7182dbc69268a6393ff4589
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(pivanov)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.