94583 - Add printing to TestGtkEmbed

Status: RESOLVED WONTFIX

(Core Graveyard :: Embedding: GTK Widget, enhancement)

Description

[MichaelWright9]

Need to add printing to the TestGtkEmbed application.

Comment 1

[MichaelWright9]

Attachment: Patch to add printing to TestGtkEmbed

Comment 2

[Christopher Blizzard (:blizzard)]

If you fix the tabbing to spaces and make sure that they are the same as in the
rest of the file r/sr=blizzard

Comment 3

[MichaelWright9]

Attachment: Fixed tabbing to spaces for new printing code.

Comment 4

[MichaelWright9]

After reviewing, can someone check this in please.

Comment 5

[MichaelWright9]

When can this be checked in? Also, can we check this in on the 0.9.2 branch also?

Comment 6

[Christopher Blizzard (:blizzard)]

You still need another review on this.

Comment 7

[Keyser Sose]

This needs to be moved to new.

Comment 8

[Christopher Blizzard (:blizzard)]

Is this patch still valid?  I seem to remember things changing with regards to
printing.

Comment 9

[MichaelWright9]

Yes, this is still valid. I'm still waiting for another review and someone to
check it in. I have been waiting for months. It is not like this is a hard one
to do. :-)

Comment 10

[Christopher Blizzard (:blizzard)]

Comment on attachment 45378 [details] [diff] [review]
Fixed tabbing to spaces for new printing code.

r/sr=blizzard

Comment 11

[Adam Lock]

r=adamlock

Please note that we may still have problems if you browse to another page while
you're printing the current one. Don, is this still the case?

Comment 12

[Kyle Yuan]

Attachment: new patch against the current trunk

Comment 13

[Christopher Blizzard (:blizzard)]

Comment on attachment 157025 [details] [diff] [review]
new patch against the current trunk

I'm not doing reviews at the moment, moving over to marco should should be
doing this at this point anyway.

Comment 14

[Marco Pesenti Gritti]

Didnt look at the patch yet, but if Christian can take a look it would be good.
This should really work for epiphany, galeon and yelp too.

blizzard, did you really mean to move superreview over to me? /me guess he cant
do superreviews.

Comment 15

[Marco Pesenti Gritti]

Ah, this just add printing to gtkmozembed, without adding C api for it. I think
that would make sense... it's a basic functionality and needed by most of
gtkmozembed users.

Christian, what do you think? Do you have ideas/proposals on how the api could look?

Comment 16

[Marco Pesenti Gritti]

Comment on attachment 157025 [details] [diff] [review]
new patch against the current trunk

This is rather old and doesnt seem to apply cleanly anymore. Though I think it
would be nice to have. Do you mind rediffing on current mozilla head and submit
it for review again?

Comment 17

[Mats Palmgren (inactive)]

TestGtkEmbed was removed 2011-04-07 in bug 648156:
https://hg.mozilla.org/mozilla-central/rev/2038ba37a2e8