945851 - Remove pref security.suppress_nss_rw_impossible_warning and which_nss_problem

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

+++ This bug was initially created as a clone of Bug #915937 +++

We should remove the preference security.suppress_nss_rw_impossible_warning and the which_nss_problem enum from nsNSSComponent::InitializeNSS. We don't need to ever show a dialog box when NSS initialization fails.

Cykesiopka, are you interested in taking this?

Comment 1

[:Cykesiopka]

(In reply to Brian Smith (:briansmith, was :bsmith; Please NEEDINFO? me if you want a response) from comment #0)
> Cykesiopka, are you interested in taking this?

Sure.

Comment 2

[:Cykesiopka]

Attachment: bug945851_v1.patch

After this patch, the indentation for the block of coding starting at:

mNSSInitialized = true;
  to
PR_LOG(gPIPNSSLog, PR_LOG_DEBUG, ("NSS Initialization done\n"));

is off, but I wasn't sure if it was worth changing blame history just for indentation.

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 8343471 [details] [diff] [review]
bug945851_v1.patch

Review of attachment 8343471 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch. Looks pretty good to me.

Please do adjust the indention. The main thing is to optimize for long-term readability of the source, not optimize for blame. We have some RFE's for our blame tools to make them easier to navigate.

THe patch needs a little more work done. In particular, all references to NSSInitProblemX need to be removed from the string bundles and anywhere else they may appear.

Comment 4

[:Cykesiopka]

(In reply to Brian Smith (:briansmith, was :bsmith; Please NEEDINFO? me if you want a response) from comment #3)
> Please do adjust the indention. The main thing is to optimize for long-term
> readability of the source, not optimize for blame. We have some RFE's for
> our blame tools to make them easier to navigate.

Ok, thanks for the info!

> THe patch needs a little more work done. In particular, all references to
> NSSInitProblemX need to be removed from the string bundles and anywhere else
> they may appear.

Ah yes, will do.

Comment 5

[:Cykesiopka]

Attachment: bug945851_v2.patch

+ Fix indentation
+ Remove NSSInitProblemX from string bundle

Comment 6

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 8343480 [details] [diff] [review]
bug945851_v2.patch

Review of attachment 8343480 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a2337e621f1

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4a2337e621f1