945913 - Bad value login-url for attribute name on element meta

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Christopher Yeleighton]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:25.0) Gecko/20100101 Firefox/25.0 (Beta/Release)
Build ID: 2013102400

Steps to reproduce:

I visited <URL: http://validator.w3.org/check?uri=https%3A%2F%2Fwebmaker.org%2Fen-US%2Fgallery >


Actual results:

Validation Output: 6 Errors

    Error Line 8, Column 62: Bad value login-url for attribute name on element meta: Keyword login-url is not registered.


Expected results:

Congratulations, etc.

Comment 1

[Christopher Yeleighton]

BTW, it seems META is being abused for something that actually is a LINK.

Comment 2

[Pomax]

Attachment: https://github.com/mozilla/webmaker.org/pull/547

turned meta element into a link element instead, as that's what it is.

Comment 3

[inactivate account for kate]

Comment on attachment 8344814 [details] [review]
https://github.com/mozilla/webmaker.org/pull/547

The js reference to this needs to be updated as well in new.js

Comment 4

[Pomax]

Comment on attachment 8344814 [details] [review]
https://github.com/mozilla/webmaker.org/pull/547

The PR already includes the change to new.js; is there another reference to it in new.js? (I couldn't find one)

Comment 5

[inactivate account for kate]

Comment on attachment 8344814 [details] [review]
https://github.com/mozilla/webmaker.org/pull/547

Apologies, I completely missed that

Comment 6

[Pomax]

Comment on attachment 8344814 [details] [review]
https://github.com/mozilla/webmaker.org/pull/547

So I patched it from one not-validating form to another. I changed the lin k relation to "login", which is a legal relation based on the list at http://wiki.whatwg.org/wiki/RelExtensions, so if you're okay with that change I'll rebase and merge in.

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/1d134da8f375f01398e42740e10e9cc3df8b97ee
Merge pull request #547 from Pomax/bug945913

turned loginurl into a proper link element instead

Comment 8

[Christopher Yeleighton]

The published page still contains the meta element.  Am I expected to run my own webmaker from your git or what?

Comment 9

[Pomax]

It's landed in master. Like all patches to webmaker projects and will get staged, and will then move on to the live site.