946062 - Disable nsIRadioInterfaceLayer in AudioManager.cpp for fixing flatfish build break.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[shawn ku [:sku]]

Disable nsIRadioInterfaceLayer in AudioManager.cpp for fixing flatfish build break.

Comment 1

[shawn ku [:sku]]

Attachment: Bug 946062 - Disable nsIRadioInterfaceLayer in AudioManager.cpp for fixing flatfish build break.

Comment 2

[shawn ku [:sku]]

Attachment: Bug 946062 - Disable nsIRadioInterfaceLayer in AudioManager.cpp for fixing flatfish build break. v2.

Comment 3

[Marco Chen [:mchen]]

Comment on attachment 8342194 [details] [diff] [review]
Bug 946062 - Disable nsIRadioInterfaceLayer in AudioManager.cpp for fixing flatfish build break. v2.

Review of attachment 8342194 [details] [diff] [review]:
-----------------------------------------------------------------

It looks good and r = me after fixing the alignment of constructor.

Thanks.

::: dom/system/gonk/AudioManager.cpp
@@ +375,5 @@
>  AudioManager::AudioManager() : mPhoneState(PHONE_STATE_CURRENT),
> +                 mObserver(new HeadphoneSwitchObserver())
> +#ifdef MOZ_B2G_RIL
> +                 ,mMuteCallToRIL(false)
> +#endif

AudioManager::AudioManager()
  : mPhoneState(PHONE_STATE_CURRENT)
  , mObserver(new HeadphoneSwitchObserver())
#ifdef MOZ_B2G_RIL
  ,mMuteCallToRIL(false)
#endif

Comment 4

[shawn ku [:sku]]

Attachment: Bug 946062 - Disable nsIRadioInterfaceLayer in AudioManager.cpp for fixing flatfish build break. r=mchen.

Comment 5

[shawn ku [:sku]]

wait try result first.

Comment 6

[shawn ku [:sku]]

Try result:
https://tbpl.mozilla.org/?tree=Try&rev=519d863ea4b7

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/1b2ba989f531

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1b2ba989f531