Disable nsIRadioInterfaceLayer in AudioManager.cpp for fixing flatfish build break.

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sku, Assigned: sku)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Disable nsIRadioInterfaceLayer in AudioManager.cpp for fixing flatfish build break.
(Assignee)

Comment 1

5 years ago
Created attachment 8342121 [details] [diff] [review]
Bug 946062 - Disable nsIRadioInterfaceLayer in AudioManager.cpp for fixing flatfish build break.
(Assignee)

Updated

5 years ago
Attachment #8342121 - Flags: review?(mchen)
(Assignee)

Comment 2

5 years ago
Created attachment 8342194 [details] [diff] [review]
Bug 946062 - Disable nsIRadioInterfaceLayer in AudioManager.cpp for fixing flatfish build break. v2.
Attachment #8342121 - Attachment is obsolete: true
Attachment #8342121 - Flags: review?(mchen)
(Assignee)

Updated

5 years ago
Attachment #8342194 - Flags: review?(mchen)

Comment 3

5 years ago
Comment on attachment 8342194 [details] [diff] [review]
Bug 946062 - Disable nsIRadioInterfaceLayer in AudioManager.cpp for fixing flatfish build break. v2.

Review of attachment 8342194 [details] [diff] [review]:
-----------------------------------------------------------------

It looks good and r = me after fixing the alignment of constructor.

Thanks.

::: dom/system/gonk/AudioManager.cpp
@@ +375,5 @@
>  AudioManager::AudioManager() : mPhoneState(PHONE_STATE_CURRENT),
> +                 mObserver(new HeadphoneSwitchObserver())
> +#ifdef MOZ_B2G_RIL
> +                 ,mMuteCallToRIL(false)
> +#endif

AudioManager::AudioManager()
  : mPhoneState(PHONE_STATE_CURRENT)
  , mObserver(new HeadphoneSwitchObserver())
#ifdef MOZ_B2G_RIL
  ,mMuteCallToRIL(false)
#endif
Attachment #8342194 - Flags: review?(mchen) → review+
(Assignee)

Comment 4

5 years ago
Created attachment 8342202 [details] [diff] [review]
Bug 946062 - Disable nsIRadioInterfaceLayer in AudioManager.cpp for fixing flatfish build break. r=mchen.
(Assignee)

Updated

5 years ago
Attachment #8342194 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Comment 5

5 years ago
wait try result first.
Keywords: checkin-needed
(Assignee)

Comment 6

5 years ago
Try result:
https://tbpl.mozilla.org/?tree=Try&rev=519d863ea4b7
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1b2ba989f531
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.