946106 - [fugu][buri]pressing enter on the keyboard does not save alarm

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Peipei Cheng (needinfo if you need my action)]

This can be reproduced on both V1.2 and V1.3

STR:
1. Launch Clock
2. Tap on "+" to open New alarm page
3. Tap on Alarm name, keyboard appears
4. Input alarm name, and press "Enter" on keyboard
   --> New alarm page is closed. Alarm is not saved.

[expected] I think we should save alarm when user press "enter".

buri V1.2 build
Gaia:     075e60c878b0eca68fba9e00bc85cb6eac03578a                         
Gecko:                                                                     
http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/14868788d50e         
BuildID   20131202004001                                                   
Version   26.0                                                             
ro.build.version.incremental=eng.archermind.20131114.105818  

buri V1.3 build
Gaia:     df070d4eed244e782dd3a7c2a7586d0741eac09f                         
Gecko:    http://hg.mozilla.org/mozilla-central/rev/9ac7ed427cd2           
BuildID   20131203151100                                                   
Version   28.0a1                                                           
ro.build.version.incremental=eng.zxliu.20131101.143946

Comment 1

[Dylan Oliver [:doliver]]

I'm not sure that we should save the alarm when you press enter since Alarm Name is just the first of many fields in alarm creation, but we definitely shouldn't dismiss the window and throw away the alarm.

Can we just dismiss the keyboard instead and leave you on the new alarm window until you either press "Done" or cancel?

Comment 2

[James Zhang (Spreadtrum)]

Attachment: enter_return_key_cause_alarm_not_saved.patch

Can we fix it on v1.3?

Comment 3

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8359036 [details] [diff] [review]
enter_return_key_cause_alarm_not_saved.patch

Review of attachment 8359036 [details] [diff] [review]:
-----------------------------------------------------------------

Hey James, thanks for the patch! Since I'm transitioning to be the new
Clock module owner and we need to get this in this week to make 1.3,
I'm grabbing the review from :ehung.

Your patch looks good to me! It was against an older commit, so
there is some trivial renaming involved; I've attached the Gaia pull
request (which I've attributed to you) with those renames to bring it
up to date with master. If all looks good there, I'll uplift to 1.3 as
a bugfix.

Comment 4

[Marcus Cavanaugh [:mcav]]

Attachment: Gaia PR, rebased to master

Comment 5

[Marcus Cavanaugh [:mcav]]

Landed in master and uplifted for 1.3 as a bugfix.

master: https://github.com/mozilla-b2g/gaia/commit/c18a8926ca20957d7ccff87ad7a7cd863bccd69
  v1.3: https://github.com/mozilla-b2g/gaia/commit/1db59bf6124b4ee46907afca7df97451c2872976