946112 - [FTE] Fix alignment of toggle

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Eric Pang [:epang] UX]

Attachment: toggle.png

Hey Pavel,

Can you move the toggle for geolocation down to 1.8rem above the subheader? (see attached image - it should be vertically center with the text). Thanks!

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: After patch screenshot

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 3

[Eric Pang [:epang] UX]

Comment on attachment 8344884 [details]
After patch screenshot

Looks good, thanks Pavel!

Comment 4

[Borja Salguero [:borjasalguero]]

Taking a look right now!

Comment 5

[Borja Salguero [:borjasalguero]]

Hi Pavel! I've just realized that we have exactly the same issue in the 'Geolocation' screen, could you fix this issue as well? Thanks!

Comment 6

[Borja Salguero [:borjasalguero]]

Comment on attachment 8344885 [details] [review]
patch for Gaia/master

Feedback+! We need to fix the same in Geolocation screen. Let me know when you are ready and I'll review again! Thanks!

Comment 7

[Borja Salguero [:borjasalguero]]

Comment on attachment 8344885 [details] [review]
patch for Gaia/master

Removing the flag until having the whole issue fixed! Please ask me to review the new patch when it will be ready! Thanks! :)

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 8344885 [details] [review]
patch for Gaia/master

Thanks :)

Comment 9

[Borja Salguero [:borjasalguero]]

Comment on attachment 8344885 [details] [review]
patch for Gaia/master

Thanks for the patch! R+ :)

Comment 10

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/5448662f7361981a994731071199b64769bead98