[FTE] Fix alignment of toggle

RESOLVED FIXED

Status

Firefox OS
Gaia::First Time Experience
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: epang, Assigned: ivanovpavel)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, jian)

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 8342210 [details]
toggle.png

Hey Pavel,

Can you move the toggle for geolocation down to 1.8rem above the subheader? (see attached image - it should be vertically center with the text). Thanks!
Created attachment 8344884 [details]
After patch screenshot
Attachment #8344884 - Flags: feedback?(epang)
Created attachment 8344885 [details] [review]
patch for Gaia/master
(Reporter)

Comment 3

5 years ago
Comment on attachment 8344884 [details]
After patch screenshot

Looks good, thanks Pavel!
Attachment #8344884 - Flags: feedback?(epang) → feedback+
Attachment #8344885 - Flags: review?(borja.bugzilla)
Taking a look right now!
Hi Pavel! I've just realized that we have exactly the same issue in the 'Geolocation' screen, could you fix this issue as well? Thanks!
Flags: needinfo?(pivanov)
Comment on attachment 8344885 [details] [review]
patch for Gaia/master

Feedback+! We need to fix the same in Geolocation screen. Let me know when you are ready and I'll review again! Thanks!
Attachment #8344885 - Flags: feedback+
Comment on attachment 8344885 [details] [review]
patch for Gaia/master

Removing the flag until having the whole issue fixed! Please ask me to review the new patch when it will be ready! Thanks! :)
Attachment #8344885 - Flags: review?(borja.bugzilla)
Comment on attachment 8344885 [details] [review]
patch for Gaia/master

Thanks :)
Attachment #8344885 - Flags: review?(borja.bugzilla)
Comment on attachment 8344885 [details] [review]
patch for Gaia/master

Thanks for the patch! R+ :)
Attachment #8344885 - Flags: review?(borja.bugzilla)
Attachment #8344885 - Flags: review+
Flags: needinfo?(pivanov)
Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/5448662f7361981a994731071199b64769bead98
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.