[LockScreen] Make lockscreen unlocking strategy customizable

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gweng, Assigned: gweng)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

To avoid a fixed strategy that can't be reused.
This is blocking Bug 945096.

After this got landed, the incoming lockscreen can be integrated.
(Assignee)

Updated

5 years ago
Assignee: nobody → gweng
(Assignee)

Comment 1

5 years ago
Created attachment 8342257 [details] [review]
Patch

Customizable, new options, modify some minor bugs.
Attachment #8342257 - Flags: review?(timdream)
(Assignee)

Updated

5 years ago
Blocks: 945096
Attachment #8342257 - Flags: review?(timdream) → review+
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
This breaks screen reader support. You got rid of the click listener.
(Assignee)

Comment 5

5 years ago
I'll fix it on Bug 943237 ASAP. The thing I am wondering is the previous implementation obviously didn't check if the `event.mozInputSource` as mentioned in the Bug 943237, but they can still work both when ScreenReader is on and off.
You need to log in before you can comment on or make changes to this bug.