946139 - [LockScreen] Make lockscreen unlocking strategy customizable

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

To avoid a fixed strategy that can't be reused.
This is blocking Bug 945096.

After this got landed, the incoming lockscreen can be integrated.

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

Customizable, new options, modify some minor bugs.

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

Travis was green: https://travis-ci.org/mozilla-b2g/gaia/builds/14964907

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/78bb5a95ea408bd5ebf588cc6a60210f92a5e85f

Comment 4

[Eitan Isaacson [:eeejay]]

This breaks screen reader support. You got rid of the click listener.

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

I'll fix it on Bug 943237 ASAP. The thing I am wondering is the previous implementation obviously didn't check if the `event.mozInputSource` as mentioned in the Bug 943237, but they can still work both when ScreenReader is on and off.