946155 - Temporarily disable fail-if tests

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Zac C (:zac)]

To enable the smooth inbound gecko changeset, temporarily disable the touch tests that are marked fail-if in the manifest files.

They are:
test_everythingme_app_install
test_everything_me_add_collection
test_edge_gestures

Afterwards the gecko patch is landed, try and re-enable these tests and also re-enable the lockscreen tests that are also marked skip-if.

See:
https://bugzilla.mozilla.org/show_bug.cgi?id=891882

Comment 1

[Trif Andrei-Alin[:AlinT]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14358

Pointer to Github pull-request

Comment 2

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8342326 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14358

The PR does seem to disable the tests.

Comment 3

[Bob Silverberg [:bsilverberg]]

The PR looks good, but I think we should open an additional bug to re-enable these tests, and also the lockscreen tests mentioned above, and have it depend on the bug that is landing the changes.  That will serve as a better reminder to try to reenable the tests than just this bug, which is for disabling them.

Comment 4

[Florin Strugariu [:Bebe]]

Comment on attachment 8342326 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14358

looks OK

Comment 5

[Florin Strugariu [:Bebe]]

This looks ready to merge

Do we still want it? Should we merge it?

Comment 6

[Zac C (:zac)]

We just need to have this ready for when Ochameau is ready to merge his Gecko change. After his Gecko change has filtered in then we can re-enable the tests. I hope the test downtime is not longer than a few hours.

I was expecting the Gecko change to come in sooner but it is taking a few weeks. 

In the meantime we don't want to disable these tests, but we can be ready to do so.

Comment 7

[Zac C (:zac)]

Bug 891882 integration was achieved without needing this.