Temporarily disable fail-if tests

RESOLVED INVALID

Status

Firefox OS
Gaia::UI Tests
RESOLVED INVALID
4 years ago
4 years ago

People

(Reporter: zac, Assigned: AlinT)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
To enable the smooth inbound gecko changeset, temporarily disable the touch tests that are marked fail-if in the manifest files.

They are:
test_everythingme_app_install
test_everything_me_add_collection
test_edge_gestures

Afterwards the gecko patch is landed, try and re-enable these tests and also re-enable the lockscreen tests that are also marked skip-if.

See:
https://bugzilla.mozilla.org/show_bug.cgi?id=891882
(Assignee)

Updated

4 years ago
Assignee: nobody → trifandreialin
(Assignee)

Comment 1

4 years ago
Created attachment 8342326 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14358

Pointer to Github pull-request
(Assignee)

Updated

4 years ago
Attachment #8342326 - Flags: review?(viorela.ioia)
Attachment #8342326 - Flags: review?(florin.strugariu)
Attachment #8342326 - Flags: review?(bob.silverberg)
Attachment #8342326 - Flags: review?(andrei.hutusoru)
Comment on attachment 8342326 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14358

The PR does seem to disable the tests.
Attachment #8342326 - Flags: review?(bob.silverberg) → review+
The PR looks good, but I think we should open an additional bug to re-enable these tests, and also the lockscreen tests mentioned above, and have it depend on the bug that is landing the changes.  That will serve as a better reminder to try to reenable the tests than just this bug, which is for disabling them.
Comment on attachment 8342326 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14358

looks OK
Attachment #8342326 - Flags: review?(florin.strugariu) → review+
Attachment #8342326 - Flags: review?(viorela.ioia) → review+
This looks ready to merge

Do we still want it? Should we merge it?
Flags: needinfo?(zcampbell)
(Reporter)

Comment 6

4 years ago
We just need to have this ready for when Ochameau is ready to merge his Gecko change. After his Gecko change has filtered in then we can re-enable the tests. I hope the test downtime is not longer than a few hours.

I was expecting the Gecko change to come in sooner but it is taking a few weeks. 

In the meantime we don't want to disable these tests, but we can be ready to do so.
Flags: needinfo?(zcampbell)
(Reporter)

Updated

4 years ago
Depends on: 891882
Priority: P1 → --
(Reporter)

Comment 7

4 years ago
Bug 891882 integration was achieved without needing this.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → INVALID

Updated

4 years ago
Attachment #8342326 - Flags: review?(andrei.hutusoru)
You need to log in before you can comment on or make changes to this bug.