Closed Bug 946183 Opened 11 years ago Closed 6 years ago

[fugu]There is some black area in video-recording preview when it back from video player

Categories

(Firefox OS Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: Dafeng.Xu, Unassigned)

Details

Attachments

(6 files)

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.22 (KHTML, like Gecko) Ubuntu Chromium/25.0.1364.160 Chrome/25.0.1364.160 Safari/537.22

Steps to reproduce:

1.start camera app and switch video mode.
2.start recording and stop it after 20s.
3.press the thumbnail in the top-left of the sreen and press the "play" button to play the video.
3.pause the video at about 10 seconds and press the "recycle" button to delete the video file.
4.it back to video-recording mode  and you can see the black area in the preview area.


Actual results:

you can sen the black area in the preview area.


Expected results:

it should back to video-recording mode and start preview.
I modify the nsTransitionManager.cpp (gecko/layout/style) and fix this bug. You can see the change in the patch, but I found another bug that associaged with this change. The bug number is 936864.
blocking-b2g: --- → fugu?
Flags: needinfo?(styang)
blocking-b2g: fugu? → ---
Flags: needinfo?(styang)
Hi Steven, it's Spreadtrum major bug, I need fugu flag.
blocking-b2g: --- → fugu?
QA,

Please check if this is reproducible on Buri?

Also check if its seen on 1.1 v/s 1.2.
Keywords: qawanted
I was unable to reproduce this issue with the steps provided on a Buri device running the latest Mozilla 1.1, 1.2, and 1.3 builds.

1.1 Environmental Variables:
Device: Buri v1.2 Mozilla RIL
BuildID: 20131210041202
Gaia: 6ff3a607f873320d00cb036fa76117f6fadd010f
Gecko: 05117f42088f
Version: 18.0
Base Image: V1.2_20131115

1.2 Environmental Variables:
Device: Buri v1.2 Mozilla RIL
BuildID: 20131210004008
Gaia: 3bede56043379283cb0f6673730f91be88018d13
Gecko: e535d93d88ad
Version: 26.0
Base Image: V1.2_20131115

1.3  Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20131210004003
Gaia: 3452fbdb5e1bed0cd27cc6173136537a03e8072f
Gecko: e0c328d99742
Version: 28.0a2
Base Image: V1.2_20131115re
Keywords: qawanted
Flags: needinfo?(vwang)
Flags: needinfo?(vliu)
Attached file Blackarea.pdf
May I explain for what I saw? 
1. When I launched camera app, it had different preview resolution when switching between picture mode and video mode. Please see Fig 1 and Fig 2 for detail. There is a "black area" upon preview screen.

2. When I done with steps to reproduce, the black area had been enlarged. Please see Fig 4 to compare the difference.

3. The enlarged black area kept about 4~5 seconds and then back to its original black area size like Fig 5.

4. I can also see the same behavior in Unagi. 

May I confirm the issue here? I need to clarify the problem. Thanks.
Flags: needinfo?(vwang)
Flags: needinfo?(vliu)
Hi! Dafeng,

Could you help Vincent to clarify this issue? Thanks.

--
Keven
Flags: needinfo?(Dafeng.Xu)
(In reply to Vincent Liu[:vliu] from comment #6)
> Created attachment 8346366 [details]
> Blackarea.pdf
> 
> May I explain for what I saw? 
> 1. When I launched camera app, it had different preview resolution when
> switching between picture mode and video mode. Please see Fig 1 and Fig 2
> for detail. There is a "black area" upon preview screen.
> 
> 2. When I done with steps to reproduce, the black area had been enlarged.
> Please see Fig 4 to compare the difference.
> 
> 3. The enlarged black area kept about 4~5 seconds and then back to its
> original black area size like Fig 5.
Since user idle for a while(a few second), films trip will be hidden automatically.
See below link:
https://github.com/mozilla-b2g/gaia/blob/master/apps/camera/js/filmstrip.js#L85
> 
> 4. I can also see the same behavior in Unagi. 
> 
> May I confirm the issue here? I need to clarify the problem. Thanks.
Flags: needinfo?(james.zhang)
(In reply to Keven Kuo [:kkuo] from comment #7)
> Hi! Dafeng,
> 
> Could you help Vincent to clarify this issue? Thanks.
> 
> --
> Keven
OK.
In video mode, the preview area's aspect ratio is dependent on the video file, such as 640X480,352X288,176X144. but in picture mode the preview area is full of screen. so you can see  the different preview resolution in picture mode and video mode.
Flags: needinfo?(Dafeng.Xu)
(In reply to Vincent Liu[:vliu] from comment #6)
> Created attachment 8346366 [details]
> Blackarea.pdf
> 
> May I explain for what I saw? 
> 1. When I launched camera app, it had different preview resolution when
> switching between picture mode and video mode. Please see Fig 1 and Fig 2
> for detail. There is a "black area" upon preview screen.
> 
> 2. When I done with steps to reproduce, the black area had been enlarged.
> Please see Fig 4 to compare the difference.
> 
> 3. The enlarged black area kept about 4~5 seconds and then back to its
> original black area size like Fig 5.
> 
> 4. I can also see the same behavior in Unagi. 
> 
> May I confirm the issue here? I need to clarify the problem. Thanks.
Hi Vincent,
    I will upload a picture to let you see the result when I reproduce this issue in fugu.
Attached image 1.jpg
(In reply to Dafeng Xu from comment #11)
> Created attachment 8346433 [details]
> 1.jpg

Thanks for your info and finally I can reproduce it.

Hi Morris,

I also tried the patch in Comment 1 and it can fix this issue. Can you have any comment for the patch? I am not familiar with Layout. Thanks.
Flags: needinfo?(mtseng)
(In reply to Dafeng Xu from comment #11)
> Created attachment 8346433 [details]
> 1.jpg

Hamachi hasn't this issue because it has NO flashlight and front camera.
Flags: needinfo?(james.zhang)
(In reply to James Zhang from comment #13)
> (In reply to Dafeng Xu from comment #11)
> > Created attachment 8346433 [details]
> > 1.jpg
> 
> Hamachi hasn't this issue because it has NO flashlight and front camera.

May I know Why you think it has any connection with flashlight and front camera? Thanks
(In reply to Vincent Liu[:vliu] from comment #14)
> (In reply to James Zhang from comment #13)
> > (In reply to Dafeng Xu from comment #11)
> > > Created attachment 8346433 [details]
> > > 1.jpg
> > 
> > Hamachi hasn't this issue because it has NO flashlight and front camera.
> 
> May I know Why you think it has any connection with flashlight and front
> camera? Thanks
The black area is flashlight and front/back camera switch button area.
It caused by bug 936864.
Attached image 2.jpg
I remove the flash button and toggle button by change the 'camera.js' file. I do the steps to reproduce, the black area is disappeared. you can see it in 'pic1'. And touch in preview area, you can see the result like 'pic2'.
Hi Evelyn,

From the result of Comment 1 and Comment 17, can you please help me to judge who should take this problem? Does it belongs to Graphic or Gaia issue? Thanks.
Flags: needinfo?(ehung)
Gary, can you help? Thanks.
Flags: needinfo?(ehung) → needinfo?(gchen)
blocking-b2g: fugu? → fugu+
Whiteboard: [Fugu] [v1.2f-uplift-needed]
Whiteboard: [Fugu] [v1.2f-uplift-needed]
(In reply to Dafeng Xu from comment #0)
> User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.22 (KHTML, like
> Gecko) Ubuntu Chromium/25.0.1364.160 Chrome/25.0.1364.160 Safari/537.22
> 
> Steps to reproduce:
> 
> 1.start camera app and switch video mode.
> 2.start recording and stop it after 20s.
> 3.press the thumbnail in the top-left of the sreen and press the "play"
> button to play the video.

I can't see "the thumbnail in the top-left of the screen", is there any patch I missed to apply?
Flags: needinfo?(Dafeng.Xu)
(In reply to Dafeng Xu from comment #1)
> I modify the nsTransitionManager.cpp (gecko/layout/style) and fix this bug.
> You can see the change in the patch, but I found another bug that associaged
> with this change. The bug number is 936864.

Partner tried to remove the patch in bug 936864 and than the issue in this bug was fixed. Can you please have any comment on this? Thanks.
Flags: needinfo?(mtseng) → needinfo?(bgirard)
(In reply to Evelyn Hung [:evelyn] from comment #20)
> (In reply to Dafeng Xu from comment #0)
> > User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.22 (KHTML, like
> > Gecko) Ubuntu Chromium/25.0.1364.160 Chrome/25.0.1364.160 Safari/537.22
> > 
> > Steps to reproduce:
> > 
> > 1.start camera app and switch video mode.
> > 2.start recording and stop it after 20s.
> > 3.press the thumbnail in the top-left of the sreen and press the "play"
> > button to play the video.
> 
> I can't see "the thumbnail in the top-left of the screen", is there any
> patch I missed to apply?

It should add a work around in gecko/gfx to fix. I believe Gary can have answer to you.
(In reply to Vincent Liu[:vliu] from comment #22)
> (In reply to Evelyn Hung [:evelyn] from comment #20)
> > (In reply to Dafeng Xu from comment #0)
> > > User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.22 (KHTML, like
> > > Gecko) Ubuntu Chromium/25.0.1364.160 Chrome/25.0.1364.160 Safari/537.22
> > > 
> > > Steps to reproduce:
> > > 
> > > 1.start camera app and switch video mode.
> > > 2.start recording and stop it after 20s.
> > > 3.press the thumbnail in the top-left of the sreen and press the "play"
> > > button to play the video.
> > 
> > I can't see "the thumbnail in the top-left of the screen", is there any
> > patch I missed to apply?
> 
> It should add a work around in gecko/gfx to fix. I believe Gary can have
> answer to you.

Yeah, I know we have this workaround patch, but others don't. If the patch is not confidential, please attach here so other people can involve. :)
(In reply to Evelyn Hung [:evelyn] from comment #23)
> (In reply to Vincent Liu[:vliu] from comment #22)
> > (In reply to Evelyn Hung [:evelyn] from comment #20)
> > > (In reply to Dafeng Xu from comment #0)
> > > > User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.22 (KHTML, like
> > > > Gecko) Ubuntu Chromium/25.0.1364.160 Chrome/25.0.1364.160 Safari/537.22
> > > > 
> > > > Steps to reproduce:
> > > > 
> > > > 1.start camera app and switch video mode.
> > > > 2.start recording and stop it after 20s.
> > > > 3.press the thumbnail in the top-left of the sreen and press the "play"
> > > > button to play the video.
> > > 
> > > I can't see "the thumbnail in the top-left of the screen", is there any
> > > patch I missed to apply?
> > 
> > It should add a work around in gecko/gfx to fix. I believe Gary can have
> > answer to you.
> 
> Yeah, I know we have this workaround patch, but others don't. If the patch
> is not confidential, please attach here so other people can involve. :)

(In reply to Vincent Liu[:vliu] from comment #22)
> (In reply to Evelyn Hung [:evelyn] from comment #20)
> > (In reply to Dafeng Xu from comment #0)
> > > User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.22 (KHTML, like
> > > Gecko) Ubuntu Chromium/25.0.1364.160 Chrome/25.0.1364.160 Safari/537.22
> > > 
> > > Steps to reproduce:
> > > 
> > > 1.start camera app and switch video mode.
> > > 2.start recording and stop it after 20s.
> > > 3.press the thumbnail in the top-left of the sreen and press the "play"
> > > button to play the video.
> > 
> > I can't see "the thumbnail in the top-left of the screen", is there any
> > patch I missed to apply?
> 
> It should add a work around in gecko/gfx to fix. I believe Gary can have
> answer to you.

Sure! Please add the patch in the below link to fix "the thumbnail can't display in the top-left of the screen". After that, you can reproduce this problem.

https://bugzilla.mozilla.org/show_bug.cgi?id=945654#c5
Assignee: nobody → gchen
Flags: needinfo?(gchen)
I found confirm() will break camera graphic performance so this might be a gecko issue, but I just submit this patch for workaround in gaia.

Hi David and John,
   Can you help to review this patch?


Since David might not have fugu device and this issue only on fugu so I ask John for review this patch and also test on fugu device.

Thanks.
Attachment #8349298 - Flags: review?(johu)
Attachment #8349298 - Flags: review?(dflanagan)
Comment on attachment 8349298 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/14798 v1.2f part

As we discussed offline, we all agree this is a gecko bug and should be fixed with gecko patch to make sure the repaint working.
Attachment #8349298 - Flags: review?(johu)
Attachment #8349298 - Flags: review?(dflanagan)
Attached video video for this bug
According to this video, the whole screen repaint is missing after we tap the ok button of confirm dialog. After that, we have a broken UI with partial confirm dialog and black preview.

In this case, we still can operate the camera app, like tapping camera switcher in this video, switch camera mode, make another video recording, toggle flash light, etc. That means we the whole HTML DOM is correct and workable but the UI is not paint correctly.
(In reply to Evelyn Hung [:evelyn] from comment #20)
> (In reply to Dafeng Xu from comment #0)
> > User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.22 (KHTML, like
> > Gecko) Ubuntu Chromium/25.0.1364.160 Chrome/25.0.1364.160 Safari/537.22
> > 
> > Steps to reproduce:
> > 
> > 1.start camera app and switch video mode.
> > 2.start recording and stop it after 20s.
> > 3.press the thumbnail in the top-left of the sreen and press the "play"
> > button to play the video.
> 
> I can't see "the thumbnail in the top-left of the screen", is there any
> patch I missed to apply?
You can ask Thomas Tsai for the patch.
Flags: needinfo?(Dafeng.Xu)
(In reply to Vincent Liu[:vliu] from comment #21)
> (In reply to Dafeng Xu from comment #1)
> > I modify the nsTransitionManager.cpp (gecko/layout/style) and fix this bug.
> > You can see the change in the patch, but I found another bug that associaged
> > with this change. The bug number is 936864.
> 
> Partner tried to remove the patch in bug 936864 and than the issue in this
> bug was fixed. Can you please have any comment on this? Thanks.

Perhaps there's a bug with async animation then which my patch is using. Someone would need to dig into it.
Flags: needinfo?(bgirard)
remove assignee since this is in 'UNCONFIRMED' status.
Assignee: gchen → nobody
[Blocking Requested - why for this release]:
Looks like this bug is not tracked anymore. Remove fugu+.
blocking-b2g: fugu+ → fugu?
Mass-modify - removal of no longer relevant blocking flags.
blocking-b2g: fugu? → ---
Firefox OS is not being worked on
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: